feat: 支持标签阈值覆盖配置#111
Open
myrat92 wants to merge 3 commits into
Open
Conversation
Collaborator
|
@myrat92 大佬,修改后的页面布局贴一下哈 |
Author
|
@Cairry 在告警条件下面会有一个标签阈值覆盖开关, 打开后可以选择标签以及标签的值 |
Collaborator
|
@myrat92 我觉得你这个设计还不错,有两个优化建议。1. 既然用了标签匹配,那么做单标签匹配可能还不够,通常可能有多个标签匹配的场景;2. 我觉得这个开关按钮还是可以复用上面的告警条件,类似这样的效果,大佬看是否有空可以优化 |
Author
|
@Cairry 感谢建议。我理解这两个优化点:
我准备调整为告警条件中增加一个可选的
另外想确认一下
|
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



变更说明
本 PR 为 Prometheus 告警规则页面增加标签阈值覆盖配置能力。
用户可以在规则配置页面开启“标签阈值覆盖”,然后基于当前 PromQL 返回的指标标签,为不同标签值配置不同的告警阈值、等级和持续时间。
主要改动
severity、expr、forDuration使用方式
关联 Issue
Refs opsre/WatchAlert#248
后端 PR
依赖后端 PR:opsre/WatchAlert#249