Skip to content

ci: propagate secrets and fix validation in S3 reusable workflows#118

Open
BKPepe wants to merge 1 commit into
openwrt:mainfrom
BKPepe:workflow-s3-fixes
Open

ci: propagate secrets and fix validation in S3 reusable workflows#118
BKPepe wants to merge 1 commit into
openwrt:mainfrom
BKPepe:workflow-s3-fixes

Conversation

@BKPepe

@BKPepe BKPepe commented Jun 15, 2026

Copy link
Copy Markdown
Member
  • Added 'secrets: inherit' to reusable build workflows in kernel.yml and packages.yml to seamlessly propagate S3 credentials.
  • Fixed reusable workflow validation errors by using env context instead of secrets context in step 'if' conditionals.
  • Enhanced S3 support in reusable_build.yml with custom endpoints and public URLs.
  • Added conditional checks in reusable_upload-file-s3.yml to skip S3 tasks if credentials are not set.

@github-actions

This comment has been minimized.

- Added 'secrets: inherit' to reusable build workflows in kernel.yml and packages.yml to seamlessly propagate S3 credentials.
- Fixed reusable workflow validation errors by using env context instead of secrets context in step 'if' conditionals.
- Enhanced S3 support in reusable_build.yml with custom endpoints and public URLs.
- Added conditional checks in reusable_upload-file-s3.yml to skip S3 tasks if credentials are not set.

Signed-off-by: Josef Schlehofer <[email protected]>
@BKPepe BKPepe force-pushed the workflow-s3-fixes branch from 8f5beee to 67ffc8a Compare June 15, 2026 18:01
@github-actions

Copy link
Copy Markdown

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit 67ffc8a

  • 🔶 Commit subject length: recommended max 60, required max 80 characters
  • 🔶 Commit body line 1 is longer than 100 characters (is 125):
    • Added 'secrets: inherit' to reusable build workflows in kernel.yml and packages.yml to seamlessly propagate S3 credentials.
  • 🔶 Commit body line 2 is longer than 100 characters (is 118):
    • Fixed reusable workflow validation errors by using env context instead of secrets context in step 'if' conditionals.
  • 🔶 Commit body line 4 is longer than 100 characters (is 102):
    • Added conditional checks in reusable_upload-file-s3.yml to skip S3 tasks if credentials are not set.

For more details, see the full job log.

Something broken? Consider providing feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant