swap_dir in test_framework fix for model reload#4319
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the functional test framework’s swap_directory() helper to better support model reload scenarios by ensuring the target directory’s parent path exists before attempting a directory swap.
Changes:
- Create the
target_pathparent directory (if needed) before renamingstaging_pathinto place. - Simplify rollback logic in the error path by removing the
target_movedflag and relying onold_pathexistence.
pgladkows
approved these changes
Jun 23, 2026
ngrozae
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the functional test framework’s swap_directory() helper to better support model reload scenarios by ensuring the target directory’s parent path exists before attempting a directory swap.
Fixes model-server.tests issues with new models export on clx6.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``