Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OpenVINO / OpenVINO GenAI dependencies to the June 22 nightly build and aligns OVMS tokenization request parsing with the expected API behavior (ensuring max_length implies truncation).
Changes:
- Bump OpenVINO / Tokenizers / GenAI source commit pins and nightly binary URLs to
2026.3.0.0.dev20260622. - Enforce OVMS tokenize API contract by setting
truncation=truewhenmax_lengthis provided. - Update demo export requirements and unit test expectations to match the new dependency/build behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
versions.mk |
Updates OpenVINO/Tokenizers/GenAI commit pins and nightly package URLs to the 2026-06-22 build. |
src/tokenize/tokenize_parser.cpp |
Sets truncation=true when parsing max_length for tokenize requests. |
src/test/tokenize_parser_test.cpp |
Updates unit test to assert truncation is set when max_length is present. |
demos/common/export_models/requirements.txt |
Bumps OpenVINO/OpenVINO-tokenizers nightly versions and the optimum-intel git pin for model export tooling. |
Comment on lines
84
to
+88
| if (it->value.IsInt()) { | ||
| size_t max_length = it->value.GetInt(); | ||
| request.parameters["max_length"] = max_length; | ||
| // Keep OVMS tokenize API contract: max_length implies truncation. | ||
| // request.parameters["truncation"] = true; | ||
| request.parameters["truncation"] = true; |
mzegla
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
🧪 Checklist
``