remove_dir_tree parameters fix for python 3.10#4310
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the functional test utility remove_dir_tree() to be compatible with Python versions older than 3.12 by selecting the correct shutil.rmtree callback parameter (onerror vs onexc).
Changes:
- Added a Python version check to pass
onexcon Python 3.12+ andonerroron older versions. - Added the required
sysimport to support the runtime version check.
ngrozae
approved these changes
Jun 22, 2026
pgladkows
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Fix remove_dir_tree shutil.rmtree parameters for python older than 3.12
🧪 Checklist
``