Add selenocysteine (Sec/U) regression tests (closes #42) - #401
Merged
Conversation
#42 (2015) observed varcode treating selenocysteines as stop codons, producing spurious StopLoss / UTR effects for selenoproteins. That no longer happens: varcode annotates against Ensembl's reference protein_sequence (full-length, with U at the recoded UGA) rather than re-translating the CDS with the standard table. Verified on GPX1 (ENST00000419783, Sec at residue 49) and locked in with regression tests covering the three paths: - substitution AT the Sec codon -> Substitution p.U49C (aa_ref="U"), not StopLoss/UTR; - substitution downstream -> p.R100W with correct numbering (read-through); - in-frame deletion upstream -> full-length mutant protein that retains U. Passes under both the fast and protein_diff annotators. Closes #42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triages and resolves #42 ("Check which apparent stop codons are actually selenocysteines", 2015).
Finding: the described bug is gone. varcode no longer treats an internal selenocysteine UGA as a stop codon. It annotates against Ensembl's reference
protein_sequence— which is full-length with aUat the recoded position — rather than re-translating the coding sequence with the standard table, so selenoprotein variants are not mis-annotated as StopLoss / UTR effects.Verification (GPX1, ENST00000419783, Sec at residue 49)
Substitution p.U49C,aa_ref="U"— missense, not StopLossp.R100W— correct numbering (read-through)UNotes
fastandprotein_diffannotators.cached_release(81)per suite convention.Closes #42
https://claude.ai/code/session_01VNtZRyKZ7u9jiMGPQEbx4c