Fix NetMHCpan version sniffing and NetMHCIIpan parsing errors - #182
Merged
Conversation
- Use os.devnull instead of bogus filename for version detection so netMHCpan doesn't error with "Unable to open(r) file" (fixes #170) - Use subprocess.run instead of check_output so non-zero exit from version sniffing doesn't raise CalledProcessError - Add ignored_value_indices to parse_netmhciipan43_stdout and parse_netmhciipan4_stdout to strip optional BindLevel indicators (<=SB, <=WB) that only appear on some rows (fixes #169) - Handle non-numeric values (e.g. NA) in score/rank/ic50 float conversion via _try_float helper, returning NaN instead of crashing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.devnullinstead of_MHCTOOLS_VERSION_SNIFFINGso netMHCpan doesn't error on a nonexistent file. Also switches tosubprocess.runto tolerate non-zero exit codes.<=SB/<=WBBindLevel indicators that only appear on some rows, and handleNAvalues in float fields gracefully (returns NaN instead of crashing).Test plan