Develop core#2
Merged
Merged
Conversation
anton-sidelnikov
requested changes
Apr 17, 2026
Member
anton-sidelnikov
left a comment
anton-sidelnikov
left a comment
There was a problem hiding this comment.
Overall really good, please review comments, problem occurred because original service from go sdk was in old style not refactored, please update service description and others things
anton-sidelnikov
requested changes
May 6, 2026
anton-sidelnikov
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guys, I implemented core part and tested it on CRUD for VPC v1. Feel free to check my code and suggest improvements