Skip to content

fix(xtest): Removes support for not-yet-ready java-sdk mlkem feature#540

Merged
dmihalcik-virtru merged 1 commit into
mainfrom
disable-pure-mlkem-java-sdk
Jun 29, 2026
Merged

fix(xtest): Removes support for not-yet-ready java-sdk mlkem feature#540
dmihalcik-virtru merged 1 commit into
mainfrom
disable-pure-mlkem-java-sdk

Conversation

@dmihalcik-virtru

@dmihalcik-virtru dmihalcik-virtru commented Jun 29, 2026

Copy link
Copy Markdown
Member

While waiting for the catch-22 on the protocol buffer enums

Summary by CodeRabbit

  • Bug Fixes
    • Updated feature detection in the command-line tool so it no longer reports support for one specific encryption mechanism check.
    • Improved how supported features are evaluated, with related checks now handled in a cleaner sequence.

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners June 29, 2026 14:53
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3dae3ea0-5382-4370-8dcd-7de9b5bd772b

📥 Commits

Reviewing files that changed from the base of the PR and between fb1ca61 and 338c01b.

📒 Files selected for processing (1)
  • xtest/sdk/java/cli.sh
💤 Files with no reviewable changes (1)
  • xtest/sdk/java/cli.sh

📝 Walkthrough

Walkthrough

Removes the mechanism-mlkem case branch from the supports subcommand feature dispatch in xtest/sdk/java/cli.sh. The branch previously checked for mlkem:768 via cmdline.jar help encrypt; its removal means mechanism-mlkem is no longer handled by the script.

Changes

Remove mechanism-mlkem support check

Layer / File(s) Summary
Remove mechanism-mlkem case branch
xtest/sdk/java/cli.sh
Deletes the 5-line mechanism-mlkem case branch from the supports feature dispatch, leaving mechanism-rsa-4096 | mechanism-ec-curves-384-521 as the next handler.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • opentdf/tests#531: Modifies the same supports feature dispatch in xtest/sdk/java/cli.sh, including changes to mechanism-mlkem/secp256r1-mlkem768 case handling.
  • opentdf/tests#538: Adds the mechanism-mlkem case branch (checking cmdline.jar help encrypt | grep -i "mlkem:768") that this PR removes.

Suggested reviewers

  • sujankota

🐰 A branch once checked for mlkem's key,
Now snipped away, clean as can be.
The dispatch moves on without a fuss,
One fewer case — no drama, no muss!
hop hop

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing xtest support for the Java SDK mlkem feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch disable-pure-mlkem-java-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the mechanism-mlkem case block from the Java CLI test script (xtest/sdk/java/cli.sh). There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@dmihalcik-virtru dmihalcik-virtru merged commit ff0dd58 into main Jun 29, 2026
19 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the disable-pure-mlkem-java-sdk branch June 29, 2026 14:56
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants