fix(deps): bump github.com/opentdf/platform/protocol/go from 0.36.0 to 0.37.0 in /sdk#3707
Conversation
…o 0.37.0 in /sdk Signed-off-by: Krish Suchak <[email protected]>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a necessary dependency bump for the sdk module to align with the latest protocol definitions. By updating the pinned version of the platform protocol, the sdk is now able to properly consume the recently introduced attribute-read RPC types, unblocking subsequent service releases. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The version bump is now in place, / To keep the SDK in pace. / With RPC types now aligned, / The build is finally refined. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesDependency Version Bump
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the github.com/opentdf/platform/protocol/go dependency in sdk/go.mod and sdk/go.sum from version v0.36.0 to v0.37.0. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
Bumps
github.com/opentdf/platform/protocol/gofrom 0.36.0 to 0.37.0 in/sdk.protocol/go v0.37.0 (released from main) contains the narrow attribute-read RPC types (
GetKeyMappingsByFqns,GetEntitleableAttributesByFqns). The sdk already consumes them via the generatedsdk/sdkconnect/attributes.gowrapper merged in #3634, butsdk/go.modstill pinned 0.36.0, so the sdk module could not build against its pinned dependency (only via the workspace).Manual dependency bump modeled on #3681. No code changes —
sdk/go.mod+sdk/go.sumonly.Unblocks the next sdk release, which the service release (#3697) depends on.
Verified:
cd sdk && GOWORK=off go build ./... && GOWORK=off go test ./... -shortpass against the pinned v0.37.0.Summary by CodeRabbit