feat(sdk): add narrow attribute read API client wrappers#3698
feat(sdk): add narrow attribute read API client wrappers#3698alkalescent wants to merge 2 commits into
Conversation
Add GetKeyMappingsByFqns and GetEntitleableAttributesByFqns RPCs to the attributes service proto with regenerated protocol/go and docs. The server methods are Unimplemented stubs here; the DB-backed implementation follows in a separate service PR so protocol/go releases first. Signed-off-by: Krish Suchak <[email protected]>
Add GetKeyMappingsByFqns and GetEntitleableAttributesByFqns to the sdkconnect AttributesServiceClient interface and connect wrapper, and implement the new methods on the authorization test mocks that satisfy that interface. Signed-off-by: Krish Suchak <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new client wrapper methods to the SDK for narrow attribute read operations. These changes facilitate future refactoring of the granter logic by providing the necessary plumbing to access key mappings and entitleable attributes via the Connect RPC client. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The SDK grows with new calls, To read the attributes behind walls. With mocks now in place, We pick up the pace, As the code base gracefully sprawls. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds two new methods, GetKeyMappingsByFqns and GetEntitleableAttributesByFqns, to the AttributesServiceClient interface and its Connect wrapper implementation. It also updates the corresponding mock clients in the authorization service tests to support these new methods. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
10d625d to
a40a66d
Compare
|
Superseded: the generated |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
Proposed Changes
SDK client wrappers for the narrow attribute read APIs. Stacked on #3634 (proto + generated code).
GetKeyMappingsByFqns/GetEntitleableAttributesByFqnsto thesdkconnect.AttributesServiceClientinterface and connect wrapper.Plumbing only: switching the granter to consume
GetKeyMappingsByFqns, plus an xtest proving split-logic parity with the previous SDK, follow in a separate feature branch.Stack
Base is #3634; rebase onto
mainonce it merges.