CNF-25075: Deduplicate TLS profile resolution logic

[sebrandon1]

Summary

• Extract resolvePredefinedProfile() helper that uses a single configv1.TLSProfiles map lookup to resolve Old/Intermediate/Modern profile types into ciphers and minTLSVersion
• Replace three repeated if-blocks in getIngressControllerTLS() and extractAPIServerTLS() with calls to the new helper
• Update getKubeletTLS() to use the same helper for consistency (it already used a map lookup but inline)
• Fix subtle fall-through in extractAPIServerTLS() where Custom profile values could theoretically be overwritten by a subsequent predefined profile match — added early return

Net: -27/+18 lines in internal/k8s/tls.go.

Jira

CNF-25075 (under CNF-23701 tls-scanner tuning epic)

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-25075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Extract resolvePredefinedProfile() helper that uses a single configv1.TLSProfiles map lookup to resolve Old/Intermediate/Modern profile types into ciphers and minTLSVersion
• Replace three repeated if-blocks in getIngressControllerTLS() and extractAPIServerTLS() with calls to the new helper
• Update getKubeletTLS() to use the same helper for consistency (it already used a map lookup but inline)
• Fix subtle fall-through in extractAPIServerTLS() where Custom profile values could theoretically be overwritten by a subsequent predefined profile match — added early return

Net: -27/+18 lines in internal/k8s/tls.go.

Jira

CNF-25075 (under CNF-23701 tls-scanner tuning epic)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign rhmdnd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.