CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67
CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67sebrandon1 wants to merge 1 commit into
Conversation
|
@sebrandon1: This pull request references CNF-23975 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2b5a396 to
5deec9f
Compare
|
/lgtm |
5deec9f to
35aa007
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
35aa007 to
bb6e1d8
Compare
richardsonnick
left a comment
There was a problem hiding this comment.
These two lines will fix the build issue
|
/lgtm |
29944a5 to
5e71529
Compare
|
Done |
|
/lgtm |
5e71529 to
10ef06c
Compare
|
New changes are detected. LGTM label has been removed. |
10ef06c to
34ee111
Compare
34ee111 to
7f8043f
Compare
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
v1import alias tocorev1fork8s.io/api/core/v1across all filesconfigv1,metav1,operatorv1Jira: CNF-23975
Files changed (7)
Production:
internal/k8s/types.go,component.go,discovery.go,process.goTests:
internal/k8s/component_test.go,discovery_test.go,internal/scanner/scanner_test.goSimilar to
Test plan
go build ./...passesgo test ./...passesgrep -rn 'v1 "k8s.io/api/core/v1"'returns zero matches