Skip to content

CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67

Open
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:rename-corev1-import
Open

CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:rename-corev1-import

Conversation

@sebrandon1

@sebrandon1 sebrandon1 commented May 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Rename the v1 import alias to corev1 for k8s.io/api/core/v1 across all files
  • Aligns with existing conventions: configv1, metav1, operatorv1
  • Pure rename — no logic changes

Jira: CNF-23975

Files changed (7)

Production: internal/k8s/types.go, component.go, discovery.go, process.go
Tests: internal/k8s/component_test.go, discovery_test.go, internal/scanner/scanner_test.go

Similar to

Test plan

  • go build ./... passes
  • go test ./... passes
  • grep -rn 'v1 "k8s.io/api/core/v1"' returns zero matches

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2026
@openshift-ci-robot

openshift-ci-robot commented May 18, 2026

Copy link
Copy Markdown

@sebrandon1: This pull request references CNF-23975 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Rename the v1 import alias to corev1 for k8s.io/api/core/v1 across all files
  • Aligns with existing conventions: configv1, metav1, operatorv1
  • Pure rename — no logic changes

Jira: CNF-23975

Files changed (7)

Production: internal/k8s/types.go, component.go, discovery.go, process.go
Tests: internal/k8s/component_test.go, discovery_test.go, internal/scanner/scanner_test.go

Test plan

  • go build ./... passes
  • go test ./... passes
  • grep -rn 'v1 "k8s.io/api/core/v1"' returns zero matches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2026
@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 2b5a396 to 5deec9f Compare May 20, 2026 15:51
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2026
@richardsonnick

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 5deec9f to 35aa007 Compare May 28, 2026 16:04
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@openshift-ci

openshift-ci Bot commented May 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please ask for approval from richardsonnick. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1

Copy link
Copy Markdown
Member Author

/retest

@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 35aa007 to bb6e1d8 Compare June 1, 2026 21:35

@richardsonnick richardsonnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines will fix the build issue

Comment thread internal/k8s/discovery.go Outdated
Comment thread internal/k8s/discovery.go Outdated
@richardsonnick

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2026
@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 29944a5 to 5e71529 Compare June 3, 2026 17:03
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2026
@sebrandon1

Copy link
Copy Markdown
Member Author

Done

@richardsonnick

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2026
@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 5e71529 to 10ef06c Compare June 8, 2026 21:55
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 10ef06c to 34ee111 Compare June 15, 2026 17:33
@sebrandon1 sebrandon1 force-pushed the rename-corev1-import branch from 34ee111 to 7f8043f Compare June 18, 2026 17:32
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants