Skip to content

CNTRLPLANE-3509: Deep-verify release component digests in nodepool resolve step #80576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 17, 2026
+16 −3
Merged

CNTRLPLANE-3509: Deep-verify release component digests in nodepool resolve step #80576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions ...try/hypershift/resolve-nodepool-releases/hypershift-resolve-nodepool-releases-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,24 @@ resolve_from_stream() {

verify_image_pullable() {
local pullspec=$1
local auth_args=""
if [[ -f "${REGISTRY_AUTH}" ]]; then
oc image info --filter-by-os linux/amd64 -a "${REGISTRY_AUTH}" "${pullspec}" &>/dev/null
else
oc image info --filter-by-os linux/amd64 "${pullspec}" &>/dev/null
auth_args="-a ${REGISTRY_AUTH}"
fi

# Check 1: release tag manifest exists and is the right architecture
# shellcheck disable=SC2086
oc image info --filter-by-os linux/amd64 ${auth_args} "${pullspec}" &>/dev/null || return 1

# Check 2: internal component digests are still alive in the registry.
# The release tag can outlive its component digests when the CI registry
# garbage-collects old images. Extract the MCO digest from the release
# metadata and verify it is actually pullable.
local mco_digest
# shellcheck disable=SC2086
mco_digest=$(oc adm release info ${auth_args} "${pullspec}" --image-for=machine-config-operator 2>/dev/null) || return 1
# shellcheck disable=SC2086
oc image info --filter-by-os linux/amd64 ${auth_args} "${mco_digest}" &>/dev/null || return 1
}

resolve_release_image() {
Expand Down