review-agent: use review URL instead of opaque GraphQL node ID

[bryan-cox]

Summary

• Review body replies were formatted as Re: review PRR_kwDOE7ekcc72sY6X which is an opaque GraphQL node ID meaningless to humans (example)
• Switched to using the review URL so replies show a clickable link like Re: https://github.com/openshift/hypershift/pull/8280#pullrequestreview-4138831511
• Duplicate detection checks for both the old node ID and new URL format for backward compatibility

Test plan

• Verify next review-agent run produces replies with clickable review URLs instead of PRR_ IDs
• Verify old replies with PRR_ node IDs are still detected as "already replied" (no duplicate responses)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved bot comment deduplication to more reliably detect and prevent duplicate responses by considering multiple review reference methods.
  • Enhanced review linkage in bot replies for clearer tracking.

[coderabbitai]

Walkthrough

Modified the review-agent script to reference reviews by URL instead of node ID. Extended the GraphQL query to fetch review URLs, updated deduplication logic to match by either ID or URL, and changed response rules to link reviews via URL rather than ID.

Changes

Cohort / File(s)	Summary
Review Reference Update ci-operator/step-registry/hypershift/review-agent/process/hypershift-review-agent-process-commands.sh	Extended GraphQL query to include review url field. Updated reply-deduplication logic to check bot comments against both review id and url. Propagated review url into needs_attention entries. Modified RESPONSE RULES to reference reviews via Re: <url> instead of Re: review <id>.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: replacing opaque GraphQL node IDs with review URLs in the review-agent process.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	The modified file is a bash script containing Python code for processing review-agent commands, not a Go test file with Ginkgo tests. No Ginkgo test patterns were found.
Test Structure And Quality	✅ Passed	This pull request does not contain any Ginkgo test code. The only file changed is a bash script that is part of the CI/CD step registry. Since the PR contains no Go test files or Ginkgo tests, this check is not applicable.
Microshift Test Compatibility	✅ Passed	PR modifies shell scripts for CI/CD review-agent tool; contains no Ginkgo e2e tests so custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only bash shell script for CI/CD review automation; does not add, modify, or introduce Ginkgo e2e tests, so check is not applicable and passes by default.
Topology-Aware Scheduling Compatibility	✅ Passed	The custom check for topology-aware scheduling compatibility is not applicable to this pull request. The check is designed to flag changes that introduce Kubernetes scheduling constraints in deployment manifests, operator code, or controllers. This PR modifies only a bash CI orchestration script with embedded Python code for GitHub PR review processing—it introduces no Kubernetes workload specifications or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable to this pull request as the modified file is a bash shell script, not a Go test binary.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only a bash shell script for the hypershift review-agent process and does not add any Ginkgo e2e tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@ci-operator/step-registry/hypershift/review-agent/process/hypershift-review-agent-process-commands.sh`:
- Around line 469-470: The dedup check using substring matching for replied =
any(str(review_id) in b or (review_url and review_url in b) for b in bot_bodies)
can yield false positives when IDs/URLs share prefixes; change the logic to
perform exact comparisons instead: parse each entry in bot_bodies to extract the
referenced review identifier or full URL (or use a regex with
anchors/word-boundaries) and compare equality against str(review_id) and
review_url, ensuring you update the check in the block that sets replied so it
only returns true for exact matches of review_id or review_url.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0855ca97-28a1-4417-a0c1-e851a265608e

📥 Commits

Reviewing files that changed from the base of the PR and between b221866 and f4f48c8.

📒 Files selected for processing (1)

• ci-operator/step-registry/hypershift/review-agent/process/hypershift-review-agent-process-commands.sh

[bryan-cox]

/retest

[enxebre]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/review-agent/process/OWNERS [bryan-cox,enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/pj-rehearse ack

[openshift-merge-bot]

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.