CLID-686, CLID-688: Add integration tests for release signature failure handling and configmap generation

[adolfo-ab]

Description

Automates OCP-77776 and OCP-76469

Github / Jira issue:

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of release signature retrieval failures during disk mirroring.
  • The operation now reports a clear error without crashing or producing an incomplete archive.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@adolfo-ab: This pull request references CLID-686 which is a valid jira issue.

Details

In response to this:

Description

Automates OCP-77776

Github / Jira issue:

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Expands integration coverage for release signature retrieval failures, generated configmap contents, cached signatures, and suppression with --ignore-release-signature.

Changes

Release signature integration coverage

Layer / File(s)	Summary
Signature behavior and configmap validation tests/integration/signature_test.go	Adds failure handling for unreachable signature endpoints, verifies generated JSON/YAML configmaps and cached signatures, and checks that ignored signatures produce no configmap files.
Integration test dependencies tests/integration/go.mod	Moves Kubernetes API and YAML packages into the direct integration-test dependency list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: aguidirh, r4f4

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	New test hardcodes OCP_SIGNATURE_URL=http://127.0.0.1:1/, an IPv4-only localhost URL that can fail in IPv6-only CI.	Use IPv6-aware loopback/dual-stack handling (or IP-family detection) instead of 127.0.0.1, and verify in the IPv6 CI job.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo titles in the changed test file are static and descriptive; none include generated or run-specific values.
Test Structure And Quality	✅ Passed	New Ginkgo tests use the repo’s setup/cleanup patterns, add temp-dir cleanup, avoid indefinite waits, and keep assertions focused and mostly well-messaged.
Microshift Test Compatibility	✅ Passed	Added tests only use local file I/O and k8s core ConfigMap structs; no MicroShift-blocked OpenShift APIs, namespaces, or unsupported assumptions.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	New signature tests only exercise local workdir/registry behavior; no node-count, scheduling, HA, or topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — the PR only changes integration tests and go.mod; it introduces no manifests, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PASS: The PR only adds test assertions/helpers in It blocks; no main/init/TestMain/BeforeSuite stdout writes or klog/log stdout setup were introduced.
No-Weak-Crypto	✅ Passed	No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were added; the new code only validates SHA256-named artifacts.
Container-Privileges	✅ Passed	PR only changes integration tests and go.mod; no container/K8s manifests or privilege settings like privileged/hostPID/allowPrivilegeEscalation were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	No new logging statements or sensitive data exposure were added; the change is limited to test assertions and local loopback env setup.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: integration tests for release signature failure handling and configmap generation.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adolfo-ab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [adolfo-ab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@adolfo-ab: This pull request references CLID-686 which is a valid jira issue.

This pull request references CLID-688 which is a valid jira issue.

Details

In response to this:

Description

Automates OCP-77776

Github / Jira issue:

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

Summary by CodeRabbit

• Bug Fixes
• Improved handling of release signature retrieval failures during disk mirroring.
• The operation now reports a clear error without crashing or producing an incomplete archive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@adolfo-ab: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.