CLID-481: docs/dev-investigations: test matrix write up#1471
Conversation
Summary of the current e2e support for running disconnected tests in CI for oc-mirror.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@r4f4: This pull request references CLID-481 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR adds a new documentation file describing a disconnected E2E testing investigation for oc-mirror. It outlines the current proxy-based disconnected AWS workflow, identifies gaps toward a true air-gap flow, lists missing step/chain components needed, and documents an implemented interim mirror-to-mirror periodic-jobs phase. ChangesDisconnected E2E Investigation Documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@r4f4: This pull request references CLID-481 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/dev-investigations/oc-mirror-disconnected-e2e.md`:
- Line 131: The step name in the disconnected E2E table is inconsistent and
should be renamed to match the existing `mirror-images-by-oc-mirror` naming used
elsewhere. Update the table entry that currently references
`mirror-images-by-oc-mirror-conf-mirror` so it uses the same identifier pattern
as the other `mirror-images-by-oc-mirror` step names, keeping the
`ipi-conf-mirror` reference intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 565e086a-b8e5-4c8e-abc4-8e6bb9db0bd8
📒 Files selected for processing (1)
docs/dev-investigations/oc-mirror-disconnected-e2e.md
| | Mirror content to disk archive (`file://`) | **No** | New: `mirror-images-by-oc-mirror-to-disk` | | ||
| | Push disk archive to offline registry | **No** | New: `mirror-images-by-oc-mirror-from-disk` | | ||
| | Enforce network isolation after mirroring | **No** | New: `aws-provision-vpc-disconnect-internet` | | ||
| | Patch install-config with mirror settings | Yes | `ipi-conf-mirror`, `mirror-images-by-oc-mirror-conf-mirror` | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
rg -n 'mirror-images-by-oc-mirror-conf-mirror|ipi-conf-mirror|mirror-images-by-oc-mirror' .Repository: openshift/oc-mirror
Length of output: 1854
docs/dev-investigations/oc-mirror-disconnected-e2e.md:131 — Rename this step name mirror-images-by-oc-mirror-conf-mirror appears only here and doesn’t match the mirror-images-by-oc-mirror naming used elsewhere, so the table points readers at a dead end.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/dev-investigations/oc-mirror-disconnected-e2e.md` at line 131, The step
name in the disconnected E2E table is inconsistent and should be renamed to
match the existing `mirror-images-by-oc-mirror` naming used elsewhere. Update
the table entry that currently references
`mirror-images-by-oc-mirror-conf-mirror` so it uses the same identifier pattern
as the other `mirror-images-by-oc-mirror` step names, keeping the
`ipi-conf-mirror` reference intact.
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
/retest |
|
@r4f4: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adolfo-ab, r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Summary of the current e2e support for running disconnected tests in CI for oc-mirror.
Github / Jira issue: CLID-481
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Expected Outcome
Please describe the outcome expected from the tests.
Summary by CodeRabbit