Skip to content

CLID-481: docs/dev-investigations: test matrix write up#1471

Open
r4f4 wants to merge 1 commit into
openshift:mainfrom
r4f4:clid-481-test-matrix-spike
Open

CLID-481: docs/dev-investigations: test matrix write up#1471
r4f4 wants to merge 1 commit into
openshift:mainfrom
r4f4:clid-481-test-matrix-spike

Conversation

@r4f4

@r4f4 r4f4 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Summary of the current e2e support for running disconnected tests in CI for oc-mirror.

Github / Jira issue: CLID-481

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Summary by CodeRabbit

  • Documentation
    • Added a new investigation guide for running OpenShift end-to-end tests in a true disconnected, air-gapped environment using mirroring.
    • Describes the desired offline test flow, current workflow gaps, and the missing reusable steps needed for a fully disconnected setup.
    • Includes an interim mirror-to-mirror job overview and a summary of related scheduled job manifests.

Summary of the current e2e support for running disconnected tests in CI
for oc-mirror.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@r4f4: This pull request references CLID-481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Description

Summary of the current e2e support for running disconnected tests in CI for oc-mirror.

Github / Jira issue: CLID-481

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4

r4f4 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

See openshift/release#81608

@openshift-ci
openshift-ci Bot requested review from aguidirh and dorzel July 8, 2026 12:47
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Walkthrough

This PR adds a new documentation file describing a disconnected E2E testing investigation for oc-mirror. It outlines the current proxy-based disconnected AWS workflow, identifies gaps toward a true air-gap flow, lists missing step/chain components needed, and documents an implemented interim mirror-to-mirror periodic-jobs phase.

Changes

Disconnected E2E Investigation Documentation

Layer / File(s) Summary
Objective and current workflow state
docs/dev-investigations/oc-mirror-disconnected-e2e.md
States the goal of simulating true air-gap E2E testing and summarizes existing proxy-based disconnected AWS workflow capabilities including bastion provisioning and direct mirroring.
Gap analysis and missing components
docs/dev-investigations/oc-mirror-disconnected-e2e.md
Identifies the gap between proxy-based simulation and true air-gap flow, and lists missing steps: disk-archive mirroring via file://, pushing archives to an offline registry with IDMS/ITMS generation, and network isolation enforcement.
Proposed workflow wiring and summary table
docs/dev-investigations/oc-mirror-disconnected-e2e.md
Specifies sequencing for a new AWS workflow/chain tying together provisioning, mirroring phases, isolation, install, and testing, plus a table summarizing existing vs. missing components.
Interim mirror-to-mirror implementation
docs/dev-investigations/oc-mirror-disconnected-e2e.md
Documents the implemented openshift-e2e-aws-m2m-disconnected interim phase and lists periodic job manifests by release branch and schedule.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the documentation write-up aspect of the PR, though it is a bit broader than the specific oc-mirror disconnected e2e investigation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a markdown docs file changed; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed PR only adds a markdown investigation doc; no Ginkgo test code or cluster-test patterns were changed, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Docs-only PR; no Ginkgo tests or API-using code were added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The commit only adds a markdown investigation doc; no Ginkgo tests or e2e code were added, so there are no SNO assumptions to flag.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds a markdown investigation doc; no manifests, controllers, or scheduling code were modified.
Ote Binary Stdout Contract ✅ Passed PR changes only add a docs/dev-investigations markdown file; no process-level code or stdout setup was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: PR only adds a docs investigation file; no It()/Describe()/Context() tests or network code were added, so the IPv4/disconnected check doesn’t apply.
No-Weak-Crypto ✅ Passed The PR only adds a docs file, and the new content contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB references or custom crypto code.
Container-Privileges ✅ Passed Doc-only change; the added markdown contains no container/K8s manifests or privilege settings like privileged, hostPID, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The added doc contains only generic workflow names and URIs like file://; no passwords, tokens, PII, internal hostnames, or customer data were found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@r4f4: This pull request references CLID-481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Description

Summary of the current e2e support for running disconnected tests in CI for oc-mirror.

Github / Jira issue: CLID-481

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Summary by CodeRabbit

  • Documentation
  • Added a new investigation guide for running OpenShift end-to-end tests in a true disconnected, air-gapped environment using mirroring.
  • Describes the desired offline test flow, current workflow gaps, and the missing reusable steps needed for a fully disconnected setup.
  • Includes an interim mirror-to-mirror job overview and a summary of related scheduled job manifests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/dev-investigations/oc-mirror-disconnected-e2e.md`:
- Line 131: The step name in the disconnected E2E table is inconsistent and
should be renamed to match the existing `mirror-images-by-oc-mirror` naming used
elsewhere. Update the table entry that currently references
`mirror-images-by-oc-mirror-conf-mirror` so it uses the same identifier pattern
as the other `mirror-images-by-oc-mirror` step names, keeping the
`ipi-conf-mirror` reference intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 565e086a-b8e5-4c8e-abc4-8e6bb9db0bd8

📥 Commits

Reviewing files that changed from the base of the PR and between bc220b6 and 0c8d1b1.

📒 Files selected for processing (1)
  • docs/dev-investigations/oc-mirror-disconnected-e2e.md

| Mirror content to disk archive (`file://`) | **No** | New: `mirror-images-by-oc-mirror-to-disk` |
| Push disk archive to offline registry | **No** | New: `mirror-images-by-oc-mirror-from-disk` |
| Enforce network isolation after mirroring | **No** | New: `aws-provision-vpc-disconnect-internet` |
| Patch install-config with mirror settings | Yes | `ipi-conf-mirror`, `mirror-images-by-oc-mirror-conf-mirror` |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
rg -n 'mirror-images-by-oc-mirror-conf-mirror|ipi-conf-mirror|mirror-images-by-oc-mirror' .

Repository: openshift/oc-mirror

Length of output: 1854


docs/dev-investigations/oc-mirror-disconnected-e2e.md:131 — Rename this step name mirror-images-by-oc-mirror-conf-mirror appears only here and doesn’t match the mirror-images-by-oc-mirror naming used elsewhere, so the table points readers at a dead end.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/dev-investigations/oc-mirror-disconnected-e2e.md` at line 131, The step
name in the disconnected E2E table is inconsistent and should be renamed to
match the existing `mirror-images-by-oc-mirror` naming used elsewhere. Update
the table entry that currently references
`mirror-images-by-oc-mirror-conf-mirror` so it uses the same identifier pattern
as the other `mirror-images-by-oc-mirror` step names, keeping the
`ipi-conf-mirror` reference intact.

@aguidirh aguidirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@nidangavali

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 0c8d1b1 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adolfo-ab, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants