Bump must-gather image reference to v4.22.0#624
Conversation
Aligns the local-storage-mustgather entry in image-references with the must-gather-image annotation in the CSV (v4.22.0). When the two strings match, doozer's _replace_image_references substitutes both occurrences with the digest-pinned production pullspec at bundle build time, which clears the olm.unpinned_references EC violation that blocked prepare-release-konflux for 5.0 ec.2.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @redhat-chai-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
Both bundles fail Konflux Enterprise Contract validation during prepare-release-konflux for 5.0 ec.2: - local-storage-operator: olm.unpinned_references on the CSV must-gather-image annotation (registry.redhat.io/openshift4/ ose-local-storage-mustgather-rhel9 with floating tag). - ptp-operator: olm.allowed_registries and olm.unpinned_references on the CSV must-gather-image annotation (quay.io/openshift/ origin-ptp-operator-must-gather:4.21). Upstream alignment fixes are in flight (must-gather refs in the CSV must match the from.name in image-references so doozer's _replace_image_references can substitute them with digest-pinned production pullspecs): - openshift/local-storage-operator#624 - openshift/ptp-operator#699 Both images have for_payload: false so disabling here does not affect the release payload; it only excludes them from the bundle/ FBC sweep for ec.2. Re-enable once the upstream PRs merge and the bundles build cleanly.
| from: | ||
| kind: DockerImage | ||
| name: registry.redhat.io/openshift4/ose-local-storage-mustgather-rhel9:v4.21.0 | ||
| name: registry.redhat.io/openshift4/ose-local-storage-mustgather-rhel9:v4.22.0 |
There was a problem hiding this comment.
Should we update CSV also with correct image name?
|
I opened #626 for |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Aligns the
local-storage-mustgatherentry inconfig/manifests/stable/image-referenceswith theoperators.openshift.io/must-gather-imageannotation in the CSV (both atv4.22.0).Why
During the 5.0 ec.2
prepare-release-konfluxrun, the LSO bundle build failed with the Enterprise Contractolm.unpinned_referencesviolation because the CSV'smust-gather-imageannotation still pointed at an upstream/floating tag instead of a digest-pinned production pullspec.doozer's
_replace_image_referencesrewrites these references to digest-pinned ART-built pullspecs at bundle build time, but only when the string in the CSV exactly matches thefrom.namedeclared inimage-references. The two were misaligned:image-referenceshad:registry.redhat.io/openshift4/ose-local-storage-mustgather-rhel9:v4.21.0registry.redhat.io/openshift4/ose-local-storage-mustgather-rhel9:v4.22.0So the substitution never matched, the raw tag was shipped in the bundle, and EC rejected it.
This PR bumps
image-referencestov4.22.0so it matches the CSV. doozer will then substitute both occurrences with the digest-pinned production pullspec and EC will pass.Context
Opened on behalf of the ART team from <https://redhat-internal.enterprise.slack.com/archives/C0ARQM5UV88/p1779227614610569|this Slack thread>.