Skip to content

CNTRLPLANE-3523: Retry on InvalidRouteTableId.NotFound during route creation #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vismishr wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −5
Open

CNTRLPLANE-3523: Retry on InvalidRouteTableId.NotFound during route creation #8747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions cmd/infra/aws/ec2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,8 @@ func (o *CreateInfraOptions) CreatePrivateRouteTable(ctx context.Context, l logr
isRetriable := func(err error) bool {
var apiErr smithy.APIError
if errors.As(err, &apiErr) {
return strings.EqualFold(apiErr.ErrorCode(), invalidNATGatewayError)
return strings.EqualFold(apiErr.ErrorCode(), invalidNATGatewayError) ||
strings.EqualFold(apiErr.ErrorCode(), invalidRouteTableID)
}
return false
}
Expand Down Expand Up @@ -553,10 +554,20 @@ func (o *CreateInfraOptions) CreatePublicRouteTable(ctx context.Context, l logr.

// Create route to internet gateway
if !o.hasInternetGatewayRoute(routeTable, igwID) {
_, err = client.CreateRoute(ctx, &ec2.CreateRouteInput{
DestinationCidrBlock: aws.String("0.0.0.0/0"),
RouteTableId: aws.String(tableID),
GatewayId: aws.String(igwID),
isRetriable := func(err error) bool {
var apiErr smithy.APIError
if errors.As(err, &apiErr) {
return strings.EqualFold(apiErr.ErrorCode(), invalidRouteTableID)
}
return false
}
err = retry.OnError(retryBackoff, isRetriable, func() error {
_, err = client.CreateRoute(ctx, &ec2.CreateRouteInput{
DestinationCidrBlock: aws.String("0.0.0.0/0"),
RouteTableId: aws.String(tableID),
GatewayId: aws.String(igwID),
})
return err
})
if err != nil {
return "", fmt.Errorf("cannot create route to internet gateway: %w", err)
Expand Down