OCPBUGS-89231: [release-4.22] reconcile HCP when pull secret is unavailable

[bryan-cox]

Summary

Cherry-pick of #8352 to release-4.22.

When a pull secret is unavailable, the HostedCluster reconciler was exiting early without reconciling the HostedControlPlane. This meant changes like NodeSelector updates were silently dropped until the pull secret was restored.

The fix reconciles the HCP before returning the pull secret error, so pod placement changes propagate independently of pull secret state.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-89231
Original fix: #8352 (OCPBUGS-77268)

Why backport?

• The operator fix is needed on release-4.22 for day-2 resilience
• TestPullSecretUnavailable (from hypershift-tests:latest built on main) permafails against release-4.22 operator without this fix
• Cherry-pick applies cleanly with no conflicts

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@bryan-cox: This pull request references Jira Issue OCPBUGS-89231, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-89231 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #8352 to release-4.22.

When a pull secret is unavailable, the HostedCluster reconciler was exiting early without reconciling the HostedControlPlane. This meant changes like NodeSelector updates were silently dropped until the pull secret was restored.

The fix reconciles the HCP before returning the pull secret error, so pod placement changes propagate independently of pull secret state.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-89231
Original fix: #8352 (OCPBUGS-77268)

Why backport?

• The operator fix is needed on release-4.22 for day-2 resilience
• TestPullSecretUnavailable (from hypershift-tests:latest built on main) permafails against release-4.22 operator without this fix
• Cherry-pick applies cleanly with no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 961796a9-446e-4531-ad31-d748e2976a89

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

Closing - the original fix (OCPBUGS-77268) targets 5.0 only with no backport planned. The right fix is to version-gate the test instead. See #8744.

[openshift-ci-robot]

@bryan-cox: This pull request references Jira Issue OCPBUGS-89231. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #8352 to release-4.22.

When a pull secret is unavailable, the HostedCluster reconciler was exiting early without reconciling the HostedControlPlane. This meant changes like NodeSelector updates were silently dropped until the pull secret was restored.

The fix reconciles the HCP before returning the pull secret error, so pod placement changes propagate independently of pull secret state.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-89231
Original fix: #8352 (OCPBUGS-77268)

Why backport?

• The operator fix is needed on release-4.22 for day-2 resilience
• TestPullSecretUnavailable (from hypershift-tests:latest built on main) permafails against release-4.22 operator without this fix
• Cherry-pick applies cleanly with no conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.