NO-JIRA: Add Sippy/CR test name annotations to v2 e2e tests#8739
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
@bryan-cox: This pull request references Jira Issue OCPBUGS-51498, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bryan-cox: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThe PR establishes and applies Sippy Component Readiness (CR) test name annotation standards across the v2 e2e test suite. The changes add mandatory Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f797eb6 to
27d9ff9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8739 +/- ##
=======================================
Coverage 41.66% 41.66%
=======================================
Files 758 758
Lines 93929 93929
=======================================
Hits 39135 39135
Misses 52046 52046
Partials 2748 2748
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Based on the review of sippy code (CNTRLPLANE-2859), some issues to resolve: 1. Suite name mismatch — blocks ingestion entirelySippy only imports test results from suites registered in // Sippy's prow.go — skips unknown suites
log.Infof("skipping suite %q as it's not listed for import", suite.Name)This is a one-line fix: RunSpecs(t, "hypershift-e2e")Without it, the annotations this PR adds won't be visible to Sippy or Component Readiness. 2.
|
Add [Jira:Hypershift] and [Feature:XYZ] annotations to all 22 v2 e2e test files for Sippy Component Readiness (CR) mapping. These annotations enable automatic Jira component assignment and per-feature regression tracking in CR dashboards. Single-feature files get both annotations on the Describe block. Multi-feature files (AWS, Azure, Security) get [Jira:Hypershift] on the Describe and [Feature:XYZ] on individual Context/When blocks. Update AGENTS.md with the annotation convention as section 19. Co-Authored-By: Claude Opus 4.6 <[email protected]>
27d9ff9 to
0acd467
Compare
|
/lgtm |
A few comments for this:
That said, those annotations should not do any harm. |
|
Scheduling tests matching the |
|
@bryan-cox: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by presubmit tests |
|
@bryan-cox: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Test Resultse2e-aws
e2e-aks
|
|
/retest |
|
/retest |
|
/override "ci/prow/e2e-kubevirt-aws-ovn-reduced" The test is permafailing and not related to this PR. |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-kubevirt-aws-ovn-reduced DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I now have all the evidence I need. Let me compile the final analysis. The root cause chain is:
This is an infrastructure/CI flake — the management cluster router pod failed its startup health check repeatedly. The PR (#8739) adds Sippy/CR test name annotations to v2 e2e tests and does not touch any cluster installation, ingress, or router code. Test Failure Analysis CompleteJob Information
Test Failure AnalysisErrorSummaryThe management cluster installation (IPI on AWS) failed because the OpenShift router pod ( Root CauseThe root cause is the router pod (
The router container kept starting (exit code 0 / "Completed"), but the startup probe killed it every time before it could become ready. After 9 restart cycles and exceeding the ProgressDeadlineExceeded timeout, the deployment remained at 0/1 ready replicas. Cascade chain:
This is a known class of transient CI infrastructure failure where the router pod cannot complete its backend sync during cluster installation. The Recommendations
Evidence
|
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Adds
[Jira:Hypershift]and[Feature:XYZ]annotations to all 22 v2 e2e test files for Sippy Component Readiness (CR) mapping. These annotations enable automatic Jira component assignment and per-feature regression tracking in CR dashboards.The e2e-azure-v2-self-managed job was promoted to standard tier in CR via sippy#3613, but without these annotations tests won't be mapped to Jira components or features. Test names must be annotated before Sippy imports them — renaming after import loses historical data.
Annotation strategy:
[Jira:Hypershift]and[Feature:XYZ]on theDescribeblock[Jira:Hypershift]on theDescribe,[Feature:XYZ]on individualContext/WhenblocksWhich issue(s) this PR fixes:
Special notes for your reviewer:
No logic changes — only string edits to Ginkgo test name strings and documentation updates. Build verified with
make e2ev2.Checklist:
Summary by CodeRabbit
Documentation
[sig-hypershift][Jira:Hypershift]and[Feature:XYZ]formats, placement rules for single- vs multi-feature files, and updated examples.Tests
"hypershift-e2e".