OCPBUGS-84327: Product-cli missing controller-runtime logger initialization causes noisy warning

[amogh-redhat]

What this PR does / why we need it:

product-cli/main.go does not initialize the controller-runtime logger, while the hypershift CLI (main.go) properly initializes it at line 43 with ctrl.SetLogger(zap.New(...)). This causes a noisy warning to be emitted during operations like create infra when using the product-cli:

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
The hypershift CLI does not produce this warning because the logger is properly initialized.

Added "ctrl.SetLogger(zap.New(...))." to the product-cli/main.go to fix the above mentioned issue.

Which issue(s) this PR fixes:

Fixes : https://redhat.atlassian.net/browse/OCPBUGS-84327

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

• Chores
  • CLI now initializes structured JSON logging at startup, improving machine-readability and consistency of log output.
  • Timestamps in logs use RFC3339 formatting for better interoperability and easier correlation across systems.
  • Result: clearer, more parseable logs to aid debugging and monitoring of CLI behavior.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates product-cli/main.go to configure controller-runtime logging at startup. It adds imports for sigs.k8s.io/controller-runtime and Zap logging (including zapcore) and, in main(), initializes a Zap JSON logger with RFC3339 time encoding and sets it as the controller-runtime logger via ctrl.SetLogger().

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Custom check is not applicable. PR modifies only product-cli/main.go for logger initialization. No Ginkgo tests are involved—tests in product-cli use standard Go testing package, not Ginkgo.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code quality is not applicable. This PR only modifies product-cli/main.go to add controller-runtime logger initialization with no test code changes.
Microshift Test Compatibility	✅ Passed	PR modifies product-cli/main.go to initialize controller-runtime logger. No Ginkgo e2e tests are added. Custom check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only modifies product-cli/main.go to initialize controller-runtime logging. No Ginkgo e2e tests are added, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only product-cli/main.go to initialize controller-runtime logger. No deployment manifests, operators, or controllers introducing scheduling constraints are added/modified.
Ote Binary Stdout Contract	✅ Passed	The PR initializes zap logging with default stderr output. No WriteTo() option or stdout configuration exists. Initialization produces no output. Matches reference implementation in main.go.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Custom check does not apply. This PR does not add any Ginkgo e2e tests—it only modifies product-cli/main.go to initialize controller-runtime logger.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding controller-runtime logger initialization to product-cli to eliminate a warning message.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.49%. Comparing base (ac1a1c2) to head (33a8aac).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
product-cli/main.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8491      +/-   ##
==========================================
- Coverage   41.50%   41.49%   -0.01%     
==========================================
  Files         758      758              
  Lines       93689    93692       +3     
==========================================
  Hits        38882    38882              
- Misses      52070    52073       +3     
  Partials     2737     2737              

Files with missing lines	Coverage Δ
product-cli/main.go	0.00% <0.00%> (ø)

Flag	Coverage Δ
cmd-support	34.86% <ø> (ø)
cpo-hostedcontrolplane	43.59% <ø> (ø)
cpo-other	43.17% <ø> (ø)
hypershift-operator	51.57% <ø> (ø)
other	31.63% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[muraee]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amogh-redhat, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [muraee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vsolanki12]

/retitle OCPBUGS-84327: Product-cli missing controller-runtime logger initialization causes noisy warning

[openshift-ci-robot]

@amogh-redhat: This pull request references Jira Issue OCPBUGS-84327, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

product-cli/main.go does not initialize the controller-runtime logger, while the hypershift CLI (main.go) properly initializes it at line 43 with ctrl.SetLogger(zap.New(...)). This causes a noisy warning to be emitted during operations like create infra when using the product-cli:

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
The hypershift CLI does not produce this warning because the logger is properly initialized.

Added "ctrl.SetLogger(zap.New(...))." to the product-cli/main.go to fix the above mentioned issue.

Which issue(s) this PR fixes:

Fixes : https://redhat.atlassian.net/browse/OCPBUGS-84327

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

• Chores
• CLI now initializes structured JSON logging at startup, improving machine-readability and consistency of log output.
• Timestamps in logs use RFC3339 formatting for better interoperability and easier correlation across systems.
• Result: clearer, more parseable logs to aid debugging and monitoring of CLI behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vsolanki12]

/jira refresh

[openshift-ci-robot]

@vsolanki12: This pull request references Jira Issue OCPBUGS-84327, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[csrwng]

/lgtm
/override "codecov/patch"

[openshift-ci]

@csrwng: Overrode contexts on behalf of csrwng: codecov/patch

Details

In response to this:

/lgtm
/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke

[csrwng]

/area cli

[hypershift-jira-solve-ci]

AI Test Failure Analysis

Job: pull-ci-openshift-hypershift-main-e2e-azure-self-managed | Build: 2064006990471892992 | Cost: $2.3434012500000003 | Failed step: hypershift-azure-run-e2e-self-managed

View full analysis report

---

_{Generated by hypershift-analyze-e2e-failure post-step using Claude claude-opus-4-6}

[amogh-redhat]

/retest

[amogh-redhat]

/retest

[sdminonne]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke

[amogh-redhat]

/retest

[hypershift-jira-solve-ci]

Now I have all the evidence I need. Let me compile the final report. The openshift-apiserver had a transient restart (restartCount=1) during startup, caused by a single startup probe failure returning HTTP 500 at 10:33:33Z. This is a well-known race condition during hosted control plane initialization where the apiserver returns 500 before it's fully ready. It's completely unrelated to the PR's change (which only adds logger initialization to product-cli/main.go).

Test Failure Analysis Complete

Job Information

• Prow Job: pull-ci-openshift-hypershift-main-e2e-aws
• Build ID: 2066819654147379200
• Target: e2e-aws
• PR: OCPBUGS-84327: Product-cli missing controller-runtime logger initialization causes noisy warning #8491 (OCPBUGS-84327: Product-cli missing controller-runtime logger initialization causes noisy warning)
• Failed Tests: 4 (TestNodePool/HostedCluster2/ValidateHostedCluster/EnsureNoCrashingPods, TestNodePool/HostedCluster2/ValidateHostedCluster, TestNodePool/HostedCluster2, TestNodePool)
• Passed Tests: 620 total, 30 skipped

Test Failure Analysis

Error

Container openshift-apiserver in pod openshift-apiserver-64db84bdcf-mhvqz has a restartCount > 0 (1)

Summary

The TestNodePool/HostedCluster2/ValidateHostedCluster/EnsureNoCrashingPods test failed because the openshift-apiserver container in the hosted control plane namespace e2e-clusters-vwkb2-node-pool-z4t6z had restartCount: 1. This was caused by a single transient startup probe failure (HTTP 500) at 10:33:33Z, just 2 seconds after the container was first started at 10:33:31Z. The container successfully restarted and became healthy. All 17 other EnsureNoCrashingPods checks across other hosted clusters passed. This failure is unrelated to the PR which only modifies product-cli/main.go to add controller-runtime logger initialization — a CLI-only change that does not affect any cluster component.

Root Cause

The failure is a transient startup race condition in the openshift-apiserver hosted control plane pod, not a product bug or a regression introduced by this PR.

Chain of events:

1. HostedCluster node-pool-z4t6z was created in namespace e2e-clusters-vwkb2 at ~10:33:18Z
2. The openshift-apiserver pod openshift-apiserver-64db84bdcf-mhvqz was scheduled and started its containers at 10:33:19Z
3. At 10:33:31Z, the openshift-apiserver container was created and started for the first time
4. At 10:33:33Z (only 2 seconds later), the startup probe fired and received HTTP 500 — the apiserver had not yet fully initialized its backends/aggregated APIs
5. Kubernetes restarted the container (restartCount incremented to 1)
6. At 10:33:32Z, the container was recreated and started successfully on second attempt
7. The EnsureNoCrashingPods validation check detects restartCount > 0 and fails the test

Why this is unrelated to PR #8491:

• The PR modifies only product-cli/main.go — adding ctrl.SetLogger(zap.New(...)) for controller-runtime logger initialization
• This is a CLI tool change (hcp command) that has zero effect on the openshift-apiserver component
• The openshift-apiserver is a completely separate binary/image from the product-cli
• Only 1 out of 18 hosted clusters experienced this startup race — confirming it is non-deterministic/transient

Recommendations

1. Retry/retest: This is a flaky failure. Retesting will almost certainly pass since the startup probe race is non-deterministic and only affected 1 out of 18 hosted clusters.
2. Known flake: The EnsureNoCrashingPods check is known to be sensitive to transient startup probe failures. The openshift-apiserver returning HTTP 500 briefly during initialization is expected behavior before all backends are ready.
3. No code changes needed: The PR's change to product-cli/main.go is completely unrelated to this failure and should not be blocked by it.

Evidence

Evidence	Detail
Failed test	TestNodePool/HostedCluster2/ValidateHostedCluster/EnsureNoCrashingPods
Error message	Container openshift-apiserver in pod openshift-apiserver-64db84bdcf-mhvqz has a restartCount > 0 (1)
Pod namespace	e2e-clusters-vwkb2-node-pool-z4t6z
Startup probe failure	Startup probe failed: HTTP probe failed with statuscode: 500 at 10:33:33Z
Container first start	10:33:31Z (only 2s before probe failure)
Container restart count	1 (single restart, then healthy)
Other EnsureNoCrashingPods	17 PASSED, 1 FAILED (only HostedCluster2)
PR change scope	product-cli/main.go only — adds ctrl.SetLogger() for logger init
Relationship to failure	None — PR modifies CLI tool, failure is in openshift-apiserver startup
Total test results	620 tests, 30 skipped, 4 failures (all from same cascade)

---

[openshift-ci]

@amogh-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	33a8aac	link	true	/test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.