CNTRLPLANE-3738: Metrics provider prometheus url be more strict#853
CNTRLPLANE-3738: Metrics provider prometheus url be more strict#853ingvagabund wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…prometheus-k8s route's host Right now there's only a single host that is valid. The list of valid hosts might get extended in the future
e535b7e to
5a80066
Compare
5a80066 to
2dff922
Compare
|
@ingvagabund: This pull request references CNTRLPLANE-3738 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Make the prometheus URL validation more strict. Allowing only a single host to be present over a secure https.
To avoid accidentally sending data over an unsecured channel or to a non-compliant URL.