Skip to content

CNTRLPLANE-3738: Metrics provider prometheus url be more strict#853

Open
ingvagabund wants to merge 2 commits into
openshift:mainfrom
ingvagabund:metrics-provider-prometheus-url-be-more-strict
Open

CNTRLPLANE-3738: Metrics provider prometheus url be more strict#853
ingvagabund wants to merge 2 commits into
openshift:mainfrom
ingvagabund:metrics-provider-prometheus-url-be-more-strict

Conversation

@ingvagabund

@ingvagabund ingvagabund commented Jun 28, 2026

Copy link
Copy Markdown
Member

Make the prometheus URL validation more strict. Allowing only a single host to be present over a secure https.

To avoid accidentally sending data over an unsecured channel or to a non-compliant URL.

@openshift-ci openshift-ci Bot requested a review from ricardomaraschini June 28, 2026 10:08
@openshift-ci

openshift-ci Bot commented Jun 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2026
…prometheus-k8s route's host

Right now there's only a single host that is valid. The list of valid
hosts might get extended in the future
@ingvagabund ingvagabund force-pushed the metrics-provider-prometheus-url-be-more-strict branch from e535b7e to 5a80066 Compare June 28, 2026 10:31
@ingvagabund ingvagabund force-pushed the metrics-provider-prometheus-url-be-more-strict branch from 5a80066 to 2dff922 Compare June 28, 2026 10:34
@ingvagabund ingvagabund changed the title Metrics provider prometheus url be more strict CNTRLPLANE-3738: Metrics provider prometheus url be more strict Jun 28, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 28, 2026

Copy link
Copy Markdown

@ingvagabund: This pull request references CNTRLPLANE-3738 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Make the prometheus URL validation more strict. Allowing only a single host to be present over a secure https.

To avoid accidentally sending data over an unsecured channel or to a non-compliant URL.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2026
@openshift-ci

openshift-ci Bot commented Jun 28, 2026

Copy link
Copy Markdown

@ingvagabund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2dff922 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants