Merge https://github.com/kubernetes-sigs/cluster-api:v1.13.3 (cf0f6c0) into main#298
Open
cloud-team-rebase-bot[bot] wants to merge 651 commits into
Open
Merge https://github.com/kubernetes-sigs/cluster-api:v1.13.3 (cf0f6c0) into main#298cloud-team-rebase-bot[bot] wants to merge 651 commits into
cloud-team-rebase-bot[bot] wants to merge 651 commits into
Conversation
📖 ClusterResourceSet is namespace scoped
…ch-deduplication 🌱 Framework: Improve pod log streaming to avoid duplicate logs
Implement the standard "Externally managed infrastructure" contract using the cluster.x-k8s.io/managed-by annotation instead of adding a new API field.
…pdate-link 📖 Fix broken link to in-place update proposal
…ally-managed-lb ✨ Support externally managed LB
…-cache-filter ✨ Add ClusterFilter to ClusterCache Options
…ology ✨ topology: implement support for taints
…nversion-tests ✨ Extend conversion tests to cover the "no spec" case
Signed-off-by: Stefan Büringer [email protected]
…nv-memory-allocations 🌱 Introduce conversion.MarshalDataUnsafeNoCopy to avoid unnecessary memory allocations during conversion
* Optimize patch calls * Address comments
…mit-MHC 🌱 Increase MHC rate limiting and filter events
Bumps the all-github-actions group with 1 update: [tj-actions/changed-files](https://github.com/tj-actions/changed-files). Updates `tj-actions/changed-files` from 47.0.4 to 47.0.5 - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@7dee1b0...22103cc) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-version: 47.0.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
… 2 updates Bumps the all-go-mod-patch-and-minor group with 1 update in the / directory: [golang.org/x/oauth2](https://github.com/golang/oauth2). Bumps the all-go-mod-patch-and-minor group with 2 updates in the /hack/tools directory: [golang.org/x/oauth2](https://github.com/golang/oauth2) and [google.golang.org/api](https://github.com/googleapis/google-api-go-client). Updates `golang.org/x/oauth2` from 0.35.0 to 0.36.0 - [Commits](golang/oauth2@v0.35.0...v0.36.0) Updates `golang.org/x/oauth2` from 0.35.0 to 0.36.0 - [Commits](golang/oauth2@v0.35.0...v0.36.0) Updates `google.golang.org/api` from 0.269.0 to 0.270.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.269.0...v0.270.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/oauth2 dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: google.golang.org/api dependency-version: 0.270.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…bot/github_actions/all-github-actions-748b815245 🌱 Bump tj-actions/changed-files from 47.0.4 to 47.0.5 in the all-github-actions group
…bot/go_modules/all-go-mod-patch-and-minor-2807cf29ba 🌱 Bump the all-go-mod-patch-and-minor group across 2 directories with 2 updates
…oisy-logs 🌱 Drop or reduce verbosity for noisy logs
* Revive the debug endpoint for CAPDev in-memery * Address comments
…is defined (kubernetes-sigs#13332) * Only set ownerReference on InfraCluster/ControlPlane when Topology is defined Signed-off-by: sivchari <[email protected]> * fix: always set ownerReference, use controller: false when topology is not defined Address review feedback: ownerReference should always be set for cascade deletion. When Topology is defined, use SetControllerReference (controller: true) so CAPI fully manages the lifecycle. When Topology is not defined, use SetOwnerReference (controller: false) to enable cascade deletion while allowing external tools to set their own controller ownerReference. * fix review findings Signed-off-by: sivchari <[email protected]> * adjust desiredOwnerRef Signed-off-by: sivchari <[email protected]> --------- Signed-off-by: sivchari <[email protected]>
…#13378) * Add validation in ClusterClass for CP MachineInfra * address review comments * add uts
* Use klog.Obj in logs * Address comments * More comments
…netes-sigs#12856) * Disable DWARF and symbol table to decrease binary/image size This commit introduces DBG variable which is used to control including DWARF and symbol table for images/binaries Signed-off-by: Sunnatillo <[email protected]> * add gogcflags.sh to defibe gcflags Signed-off-by: Sunnatillo <[email protected]> --------- Signed-off-by: Sunnatillo <[email protected]>
…-wrapper-poc 🐛 Fix exponential backoff with ReconcilerRateLimiting
Signed-off-by: Stefan Büringer [email protected]
…-v1.25.8 🌱 Bump go v1.25.8
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
config/crd/bases/cluster.x-k8s.io_clusters.yaml (1)
1-1:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd the required code-PR label before merge.
The PR currently only has
needs-ok-to-test, but code PRs must carry one of the required release-note labels (⚠️,✨,🐛,📖, or🌱). As per coding guidelines, “All code PR must be labeled with one of …”. Based on learnings, “All code PRs must be labeled with one of:⚠️ … ✨ … 🐛 … 📖 … 🌱 …”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/crd/bases/cluster.x-k8s.io_clusters.yaml` at line 1, This pull request requires a release-note label in addition to the existing needs-ok-to-test label before it can be merged. Add one of the required code-PR labels (⚠️ for breaking changes, ✨ for features, 🐛 for bug fixes, 📖 for documentation, or 🌱 for improvements) to the pull request based on the nature of the changes made in this code modification.Sources: Coding guidelines, Learnings
♻️ Duplicate comments (7)
CHANGELOG/v1.13.0-beta.0.md (1)
81-81:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix the double-space typo in the Runtime SDK bullet.
Use
client cert/keyinstead ofclient cert/key.Suggested fix
-- Runtime SDK: Improve client cert/key rotation of the RuntimeSDK client (`#13213`) +- Runtime SDK: Improve client cert/key rotation of the RuntimeSDK client (`#13213`)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG/v1.13.0-beta.0.md` at line 81, The changelog entry for the Runtime SDK contains a double-space typo between "client" and "cert/key" in the bullet point at line 81. Find the text "Improve client cert/key rotation" and replace the double space with a single space so it reads "Improve client cert/key rotation".CHANGELOG/v1.13.0-rc.0.md (1)
123-123:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix the double-space typo in the Runtime SDK bullet.
Use
client cert/keyinstead ofclient cert/key.Suggested fix
- Runtime SDK: Improve client cert/key rotation of the RuntimeSDK client (`#13213`) + Runtime SDK: Improve client cert/key rotation of the RuntimeSDK client (`#13213`)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG/v1.13.0-rc.0.md` at line 123, The changelog entry for the Runtime SDK bullet point contains a double-space typo between "client" and "cert/key" in the line "Improve client cert/key rotation of the RuntimeSDK client (`#13213`)". Remove the extra space to make it "Improve client cert/key rotation of the RuntimeSDK client (`#13213`)" so there is only a single space between the words.CHANGELOG/v1.13.0-beta.1.md (1)
148-148:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix the double-space typo in the Runtime SDK bullet.
Use
client cert/keyinstead ofclient cert/key.Suggested fix
- Runtime SDK: Improve client cert/key rotation of the RuntimeSDK client (`#13213`) + Runtime SDK: Improve client cert/key rotation of the RuntimeSDK client (`#13213`)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG/v1.13.0-beta.1.md` at line 148, In the CHANGELOG file for v1.13.0-beta.1.md, locate the Runtime SDK bullet point about client cert/key rotation. Remove the extra space between the word "client" and "cert/key" so that it reads "client cert/key" instead of "client cert/key", ensuring proper formatting consistency in the changelog entry..github/workflows/weekly-security-scan.yaml (1)
20-23:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDisable credential persistence on checkout.
Line 21 still leaves credentials in git config; add
persist-credentials: false.Suggested fix
- name: Check out code uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # tag=v6.0.2 with: ref: ${{ matrix.branch }} + persist-credentials: falseAs per coding guidelines, CI/CD security (prodsec-skills) requires least-privilege token handling.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/weekly-security-scan.yaml around lines 20 - 23, The actions/checkout action in the "Check out code" step is leaving credentials in git config by persisting them. Add persist-credentials: false to the with block of the actions/checkout step to disable credential persistence and follow least-privilege token handling practices as per CI/CD security guidelines.Sources: Coding guidelines, Linters/SAST tools
.github/workflows/pr-md-link-check.yaml (1)
17-17:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDisable credential persistence on checkout.
Line 17 still leaves the workflow token in git config; add
persist-credentials: false.Suggested fix
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # tag=v6.0.2 + with: + persist-credentials: falseAs per coding guidelines, CI/CD security (prodsec-skills) requires least-privilege token handling.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pr-md-link-check.yaml at line 17, The actions/checkout step is missing the persist-credentials configuration parameter. Add `persist-credentials: false` as a parameter to the checkout action (the step using actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd) to prevent the workflow token from being left in git config, ensuring least-privilege token handling.Sources: Coding guidelines, Linters/SAST tools
.github/workflows/release.yaml (2)
19-23:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDisable credential persistence on both checkout steps.
Both checkout steps still persist credentials; add
persist-credentials: falsein eachwith:block.Suggested fix
- name: Checkout code uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # tag=v6.0.2 with: fetch-depth: 0 + persist-credentials: false @@ - name: checkout code uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # tag=v6.0.2 with: fetch-depth: 0 ref: ${{ env.RELEASE_TAG }} + persist-credentials: falseAs per coding guidelines, CI/CD security (prodsec-skills) calls for least-privilege token handling.
Also applies to: 90-94
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yaml around lines 19 - 23, Both checkout steps in the release.yaml workflow are persisting credentials by default, which violates security best practices for least-privilege token handling. Add `persist-credentials: false` to the `with:` block of the first checkout step (the one named "Checkout code" with `actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd`), and also add the same parameter to the second checkout step referenced around line 90-94. This ensures credentials are not persisted to disk after the checkout operations complete.Sources: Coding guidelines, Linters/SAST tools
97-100:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDisable setup-go caching in the release job.
Line 98 still enables implicit cache restore/save; set
cache: falsehere.Suggested fix
- name: Set up Go uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # tag=v6.4.0 with: go-version: ${{ env.go_version }} + cache: falseAs per coding guidelines, keep release workflows hardened and minimize cache attack surface.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yaml around lines 97 - 100, The Set up Go action using actions/setup-go currently enables caching implicitly, which increases the attack surface in the release workflow. Add a cache property set to false in the with section of this action to explicitly disable caching, ensuring the release job follows hardening guidelines and does not use any cached Go dependencies.Sources: Coding guidelines, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 847-885: The docker-build-docker-infrastructure target passes
build arguments for gcflags and ldflags to the Docker build command via
--build-arg flags, but the Dockerfile referenced by $(CAPD_DIR) is missing the
corresponding ARG declarations. Add ARG gcflags and ARG ldflags declarations at
the beginning of the Dockerfile used by the docker-build-docker-infrastructure
target to ensure these build arguments are properly recognized in the Docker
build context.
---
Outside diff comments:
In `@config/crd/bases/cluster.x-k8s.io_clusters.yaml`:
- Line 1: This pull request requires a release-note label in addition to the
existing needs-ok-to-test label before it can be merged. Add one of the required
code-PR labels (⚠️ for breaking changes, ✨ for features, 🐛 for bug fixes, 📖
for documentation, or 🌱 for improvements) to the pull request based on the
nature of the changes made in this code modification.
---
Duplicate comments:
In @.github/workflows/pr-md-link-check.yaml:
- Line 17: The actions/checkout step is missing the persist-credentials
configuration parameter. Add `persist-credentials: false` as a parameter to the
checkout action (the step using
actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd) to prevent the
workflow token from being left in git config, ensuring least-privilege token
handling.
In @.github/workflows/release.yaml:
- Around line 19-23: Both checkout steps in the release.yaml workflow are
persisting credentials by default, which violates security best practices for
least-privilege token handling. Add `persist-credentials: false` to the `with:`
block of the first checkout step (the one named "Checkout code" with
`actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd`), and also add the
same parameter to the second checkout step referenced around line 90-94. This
ensures credentials are not persisted to disk after the checkout operations
complete.
- Around line 97-100: The Set up Go action using actions/setup-go currently
enables caching implicitly, which increases the attack surface in the release
workflow. Add a cache property set to false in the with section of this action
to explicitly disable caching, ensuring the release job follows hardening
guidelines and does not use any cached Go dependencies.
In @.github/workflows/weekly-security-scan.yaml:
- Around line 20-23: The actions/checkout action in the "Check out code" step is
leaving credentials in git config by persisting them. Add persist-credentials:
false to the with block of the actions/checkout step to disable credential
persistence and follow least-privilege token handling practices as per CI/CD
security guidelines.
In `@CHANGELOG/v1.13.0-beta.0.md`:
- Line 81: The changelog entry for the Runtime SDK contains a double-space typo
between "client" and "cert/key" in the bullet point at line 81. Find the text
"Improve client cert/key rotation" and replace the double space with a single
space so it reads "Improve client cert/key rotation".
In `@CHANGELOG/v1.13.0-beta.1.md`:
- Line 148: In the CHANGELOG file for v1.13.0-beta.1.md, locate the Runtime SDK
bullet point about client cert/key rotation. Remove the extra space between the
word "client" and "cert/key" so that it reads "client cert/key" instead of
"client cert/key", ensuring proper formatting consistency in the changelog
entry.
In `@CHANGELOG/v1.13.0-rc.0.md`:
- Line 123: The changelog entry for the Runtime SDK bullet point contains a
double-space typo between "client" and "cert/key" in the line "Improve client
cert/key rotation of the RuntimeSDK client (`#13213`)". Remove the extra space to
make it "Improve client cert/key rotation of the RuntimeSDK client (`#13213`)" so
there is only a single space between the words.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7dfce8be-9a22-434a-8671-e8c683e60958
⛔ Files ignored due to path filters (28)
api/bootstrap/kubeadm/v1beta1/zz_generated.conversion.gois excluded by!**/zz_generated*api/bootstrap/kubeadm/v1beta1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/bootstrap/kubeadm/v1beta2/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/controlplane/kubeadm/v1beta1/zz_generated.conversion.gois excluded by!**/zz_generated*api/controlplane/kubeadm/v1beta1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/controlplane/kubeadm/v1beta2/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/core/v1beta1/zz_generated.conversion.gois excluded by!**/zz_generated*api/core/v1beta1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/core/v1beta1/zz_generated.openapi.gois excluded by!**/zz_generated*api/core/v1beta2/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/core/v1beta2/zz_generated.openapi.gois excluded by!**/zz_generated*api/runtime/hooks/v1alpha1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/runtime/hooks/v1alpha1/zz_generated.openapi.gois excluded by!**/zz_generated*docs/book/src/images/clusterclass-crd-relationships.svgis excluded by!**/*.svgdocs/book/src/images/kubeadm-control-plane-machines-resources.pngis excluded by!**/*.pngdocs/book/src/images/worker-machines-resources.pngis excluded by!**/*.pnggo.sumis excluded by!**/*.sumhack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/cloud.google.com/go/auth/CHANGES.mdis excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/credentials/detect.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/credentials/filetypes.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/credentials/internal/gdch/gdch.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/grpctransport/grpctransport.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/httptransport/httptransport.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/httptransport/transport.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/internal/credsfile/credsfile.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/internal/credsfile/filetype.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/internal/credsfile/parse.gois excluded by!**/vendor/**
📒 Files selected for processing (272)
.ci-operator.yaml.dockerignore.github/workflows/pr-gh-workflow-approve.yaml.github/workflows/pr-md-link-check.yaml.github/workflows/release.yaml.github/workflows/weekly-md-link-check.yaml.github/workflows/weekly-security-scan.yaml.github/workflows/weekly-test-release.yaml.golangci-kal.yml.golangci.yml.trivyignoreCHANGELOG/v1.10.10.mdCHANGELOG/v1.10.9.mdCHANGELOG/v1.11.4.mdCHANGELOG/v1.11.5.mdCHANGELOG/v1.11.6.mdCHANGELOG/v1.11.7.mdCHANGELOG/v1.12.0-rc.1.mdCHANGELOG/v1.12.0.mdCHANGELOG/v1.12.1.mdCHANGELOG/v1.12.2.mdCHANGELOG/v1.12.3.mdCHANGELOG/v1.12.4.mdCHANGELOG/v1.13.0-beta.0.mdCHANGELOG/v1.13.0-beta.1.mdCHANGELOG/v1.13.0-rc.0.mdCONTRIBUTING.mdDockerfileMakefileTiltfileapi/bootstrap/kubeadm/v1beta1/conversion.goapi/bootstrap/kubeadm/v1beta1/kubeadm_types.goapi/bootstrap/kubeadm/v1beta1/kubeadmconfig_types.goapi/bootstrap/kubeadm/v1beta2/kubeadmconfig_types.goapi/controlplane/kubeadm/v1beta1/conversion.goapi/controlplane/kubeadm/v1beta1/kubeadm_control_plane_types.goapi/controlplane/kubeadm/v1beta1/kubeadmcontrolplanetemplate_types.goapi/controlplane/kubeadm/v1beta2/kubeadm_control_plane_types.goapi/controlplane/kubeadm/v1beta2/kubeadmcontrolplanetemplate_types.goapi/core/v1beta1/cluster_types.goapi/core/v1beta1/clusterclass_types.goapi/core/v1beta1/common_types.goapi/core/v1beta1/conversion.goapi/core/v1beta1/conversion_test.goapi/core/v1beta1/machine_types.goapi/core/v1beta1/machinehealthcheck_types.goapi/core/v1beta2/cluster_types.goapi/core/v1beta2/clusterclass_types.goapi/core/v1beta2/common_types.goapi/core/v1beta2/condition_types.goapi/core/v1beta2/machine_types.goapi/ipam/v1alpha1/conversion.goapi/runtime/hooks/v1alpha1/common_types.goapi/runtime/hooks/v1alpha1/lifecyclehooks_types.goapi/runtime/hooks/v1alpha1/topologymutation_types.goapi/runtime/hooks/v1alpha1/topologymutation_variable_types.gobootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yamlbootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yamlbootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigs.yamlbootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigtemplates.yamlbootstrap/kubeadm/config/manager/manager.yamlbootstrap/kubeadm/config/webhook/manifests.yamlbootstrap/kubeadm/internal/cloudinit/cloudinit_test.gobootstrap/kubeadm/internal/cloudinit/disk_setup.gobootstrap/kubeadm/internal/cloudinit/utils.gobootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.gobootstrap/kubeadm/internal/controllers/suite_test.gobootstrap/kubeadm/internal/locking/control_plane_init_mutex.gobootstrap/kubeadm/internal/setup/setup.gobootstrap/kubeadm/internal/webhooks/kubeadmconfig.gobootstrap/kubeadm/internal/webhooks/kubeadmconfig_test.gobootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate.gobootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate_test.gobootstrap/kubeadm/main.gobootstrap/util/configowner_test.gobootstrap/util/suite_test.gocmd/clusterctl/Dockerfilecmd/clusterctl/client/cluster/cert_manager.gocmd/clusterctl/client/cluster/cert_manager_test.gocmd/clusterctl/client/cluster/mover.gocmd/clusterctl/client/cluster/template.gocmd/clusterctl/client/cluster/template_test.gocmd/clusterctl/client/cluster/upgrader.gocmd/clusterctl/client/cluster/upgrader_test.gocmd/clusterctl/client/config/imagemeta_client.gocmd/clusterctl/client/config/imagemeta_client_test.gocmd/clusterctl/client/config/providers_client.gocmd/clusterctl/client/config_test.gocmd/clusterctl/client/repository/repository_github.gocmd/clusterctl/client/repository/repository_github_test.gocmd/clusterctl/client/upgrade.gocmd/clusterctl/cmd/config_repositories_test.gocmd/clusterctl/cmd/describe_cluster.gocmd/clusterctl/cmd/upgrade_apply.gocmd/clusterctl/cmd/version_checker.gocmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_metadata.yamlcmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_providers.yamlcmd/clusterctl/config/manifest/clusterctl-api.yamlcmd/clusterctl/hack/create-local-repository.pycmd/clusterctl/internal/test/fake_github.gocmd/clusterctl/internal/test/fake_reader.goconfig/crd/bases/addons.cluster.x-k8s.io_clusterresourcesetbindings.yamlconfig/crd/bases/addons.cluster.x-k8s.io_clusterresourcesets.yamlconfig/crd/bases/cluster.x-k8s.io_clusterclasses.yamlconfig/crd/bases/cluster.x-k8s.io_clusters.yamlconfig/crd/bases/cluster.x-k8s.io_machinedeployments.yamlconfig/crd/bases/cluster.x-k8s.io_machinedrainrules.yamlconfig/crd/bases/cluster.x-k8s.io_machinehealthchecks.yamlconfig/crd/bases/cluster.x-k8s.io_machinepools.yamlconfig/crd/bases/cluster.x-k8s.io_machines.yamlconfig/crd/bases/cluster.x-k8s.io_machinesets.yamlconfig/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yamlconfig/crd/bases/ipam.cluster.x-k8s.io_ipaddresses.yamlconfig/crd/bases/runtime.cluster.x-k8s.io_extensionconfigs.yamlconfig/crd/patches/webhook_in_clusterclasses.yamlconfig/crd/patches/webhook_in_clusterresourcesetbindings.yamlconfig/crd/patches/webhook_in_clusterresourcesets.yamlconfig/crd/patches/webhook_in_clusters.yamlconfig/crd/patches/webhook_in_extensionconfigs.yamlconfig/crd/patches/webhook_in_ipaddressclaims.yamlconfig/crd/patches/webhook_in_ipaddresses.yamlconfig/crd/patches/webhook_in_machinedeployments.yamlconfig/crd/patches/webhook_in_machinedrainrules.yamlconfig/crd/patches/webhook_in_machinehealthchecks.yamlconfig/crd/patches/webhook_in_machinepools.yamlconfig/crd/patches/webhook_in_machines.yamlconfig/crd/patches/webhook_in_machinesets.yamlconfig/manager/manager.yamlconfig/metrics/crd-metrics-config.yamlconfig/webhook/manifests.yamlcontrollers/clustercache/cluster_accessor.gocontrollers/clustercache/cluster_accessor_client.gocontrollers/clustercache/cluster_accessor_test.gocontrollers/clustercache/cluster_cache.gocontrollers/clustercache/cluster_cache_test.gocontrollers/crdmigrator/crd_migrator.gocontrollers/crdmigrator/test/t1/crd/test.cluster.x-k8s.io_testclusters.yamlcontrollers/crdmigrator/test/t2/crd/test.cluster.x-k8s.io_testclusters.yamlcontrollers/crdmigrator/test/t3/crd/test.cluster.x-k8s.io_testclusters.yamlcontrollers/crdmigrator/test/t4/crd/test.cluster.x-k8s.io_testclusters.yamlcontrolplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanes.yamlcontrolplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanetemplates.yamlcontrolplane/kubeadm/config/crd/patches/webhook_in_kubeadmcontrolplanes.yamlcontrolplane/kubeadm/config/crd/patches/webhook_in_kubeadmcontrolplanetemplates.yamlcontrolplane/kubeadm/config/manager/manager.yamlcontrolplane/kubeadm/config/webhook/manifests.yamlcontrolplane/kubeadm/internal/cluster.gocontrolplane/kubeadm/internal/cluster_test.gocontrolplane/kubeadm/internal/clustercache_utils.gocontrolplane/kubeadm/internal/control_plane.gocontrolplane/kubeadm/internal/control_plane_test.gocontrolplane/kubeadm/internal/controllers/controller.gocontrolplane/kubeadm/internal/controllers/controller_test.gocontrolplane/kubeadm/internal/controllers/fakes_test.gocontrolplane/kubeadm/internal/controllers/helpers.gocontrolplane/kubeadm/internal/controllers/inplace.gocontrolplane/kubeadm/internal/controllers/inplace_canupdatemachine.gocontrolplane/kubeadm/internal/controllers/inplace_canupdatemachine_test.gocontrolplane/kubeadm/internal/controllers/inplace_trigger.gocontrolplane/kubeadm/internal/controllers/remediation.gocontrolplane/kubeadm/internal/controllers/remediation_test.gocontrolplane/kubeadm/internal/controllers/scale.gocontrolplane/kubeadm/internal/controllers/scale_test.gocontrolplane/kubeadm/internal/controllers/status.gocontrolplane/kubeadm/internal/controllers/status_test.gocontrolplane/kubeadm/internal/controllers/suite_test.gocontrolplane/kubeadm/internal/controllers/update.gocontrolplane/kubeadm/internal/controllers/update_test.gocontrolplane/kubeadm/internal/desiredstate/desired_state.gocontrolplane/kubeadm/internal/desiredstate/desired_state_test.gocontrolplane/kubeadm/internal/etcd/etcd_test.gocontrolplane/kubeadm/internal/etcd/fake/client.gocontrolplane/kubeadm/internal/setup/setup.gocontrolplane/kubeadm/internal/suite_test.gocontrolplane/kubeadm/internal/webhooks/kubeadmcontrolplane.gocontrolplane/kubeadm/internal/webhooks/kubeadmcontrolplane_test.gocontrolplane/kubeadm/internal/webhooks/kubeadmcontrolplanetemplate.gocontrolplane/kubeadm/internal/webhooks/scale.gocontrolplane/kubeadm/internal/workload_cluster.gocontrolplane/kubeadm/internal/workload_cluster_conditions.gocontrolplane/kubeadm/internal/workload_cluster_conditions_test.gocontrolplane/kubeadm/internal/workload_cluster_coredns.gocontrolplane/kubeadm/internal/workload_cluster_etcd.gocontrolplane/kubeadm/internal/workload_cluster_etcd_test.gocontrolplane/kubeadm/internal/workload_cluster_rbac.gocontrolplane/kubeadm/internal/workload_cluster_rbac_test.gocontrolplane/kubeadm/internal/workload_cluster_test.gocontrolplane/kubeadm/main.godocs/book/src/SUMMARY.mddocs/book/src/clusterctl/configuration.mddocs/book/src/developer/core/logging.mddocs/book/src/developer/core/tilt.mddocs/book/src/developer/providers/contracts/bootstrap-config.mddocs/book/src/developer/providers/contracts/clusterctl.mddocs/book/src/developer/providers/contracts/control-plane.mddocs/book/src/developer/providers/contracts/infra-cluster.mddocs/book/src/developer/providers/contracts/infra-machine.mddocs/book/src/developer/providers/contracts/infra-machinepool.mddocs/book/src/developer/providers/getting-started/webhooks.mddocs/book/src/developer/providers/migrations/v1.10-to-v1.11.mddocs/book/src/developer/providers/migrations/v1.12-to-v1.13.mddocs/book/src/developer/providers/migrations/v1.9-to-v1.10.mddocs/book/src/images/kubeadm-control-plane-machines-resources.plantumldocs/book/src/images/worker-machines-resources.plantumldocs/book/src/introduction.mddocs/book/src/reference/api/crd-api-reference-v1beta1.mddocs/book/src/reference/api/crd-api-reference.mddocs/book/src/reference/api/crd-relationships.mddocs/book/src/reference/api/reference.mddocs/book/src/reference/versions.mddocs/book/src/tasks/automated-machine-management/healthchecking.mddocs/book/src/tasks/automated-machine-management/scaling.mddocs/book/src/tasks/cluster-resource-set.mddocs/book/src/tasks/diagnostics.mddocs/book/src/tasks/experimental-features/cluster-class/write-clusterclass.mddocs/book/src/tasks/experimental-features/experimental-features.mddocs/book/src/tasks/experimental-features/machine-pools.mddocs/book/src/tasks/experimental-features/runtime-sdk/implement-extensions.mddocs/book/src/tasks/experimental-features/runtime-sdk/index.mddocs/book/src/tasks/external-etcd.mddocs/book/src/tasks/using-kustomize.mddocs/book/src/user/quick-start.mddocs/proposals/20200506-conditions.mddocs/proposals/20210310-opt-in-autoscaling-from-zero.mddocs/proposals/20220330-topology-mutation-hook.mddocs/proposals/20240916-improve-status-in-CAPI-resources.mddocs/proposals/20250124-From CAPD(docker) to CAPD(dev) .mddocs/release/releases/release-1.13.mddocs/release/role-handbooks/ci-signal/README.mddocs/release/role-handbooks/release-lead/README.mdexp/topology/desiredstate/desired_state.goexp/topology/desiredstate/desired_state_test.goexp/topology/desiredstate/lifecycle_hooks.goexp/topology/desiredstate/lifecycle_hooks_test.goexp/topology/desiredstate/upgrade_plan.goexp/topology/desiredstate/upgrade_plan_test.gofeature/feature.gogo.modhack/crd-ref-docs-config-v1beta1.yamlhack/crd-ref-docs-config-v1beta2.yamlhack/ensure-go.shhack/gogcflags.shhack/kind-install.shhack/observability/alloy/kustomization.yamlhack/observability/grafana/chart/kustomization.yamlhack/observability/grafana/dashboards/cluster-api-mgmt-apiserver-requests.jsonhack/observability/grafana/dashboards/cluster-api-performance.jsonhack/observability/grafana/dashboards/cluster-api-state.jsonhack/observability/grafana/dashboards/cluster-api-wl-apiserver-requests.jsonhack/observability/grafana/dashboards/controller-runtime.jsonhack/observability/grafana/dashboards/runtime-extensions.jsonhack/observability/kube-state-metrics/crd-sidecar-patch.yamlhack/observability/kube-state-metrics/kustomization.yamlhack/observability/loki/kustomization.yamlhack/observability/loki/values.yamlhack/observability/metrics-server/kustomization.yamlhack/observability/parca/values.yamlhack/observability/prometheus/kustomization.yamlhack/observability/prometheus/values.yamlhack/observability/tempo/kustomization.yamlhack/observability/visualizer/kustomization.yamlhack/tools/go.modhack/tools/govulncheck/.gitignorehack/tools/govulncheck/govulncheck.patchhack/tools/internal/tilt-prepare/main.gohack/tools/prowjob-gen/config.gohack/tools/prowjob-gen/test/test-configuration.yamlhack/tools/prowjob-gen/test/test-main.yaml.goldenhack/tools/prowjob-gen/test/test.yaml.tplhack/tools/release/internal/update_providers/provider_issues.gohack/tools/release/weekly/main.gohack/tools/runtime-openapi-gen/main.go
💤 Files with no reviewable changes (7)
- .trivyignore
- bootstrap/util/suite_test.go
- bootstrap/kubeadm/config/webhook/manifests.yaml
- .github/workflows/pr-gh-workflow-approve.yaml
- cmd/clusterctl/client/cluster/upgrader_test.go
- controllers/clustercache/cluster_accessor_test.go
- config/webhook/manifests.yaml
✅ Files skipped from review due to trivial changes (28)
- config/crd/patches/webhook_in_machinehealthchecks.yaml
- cmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_providers.yaml
- controllers/crdmigrator/test/t1/crd/test.cluster.x-k8s.io_testclusters.yaml
- config/crd/bases/cluster.x-k8s.io_machinedrainrules.yaml
- .ci-operator.yaml
- controllers/crdmigrator/test/t2/crd/test.cluster.x-k8s.io_testclusters.yaml
- cmd/clusterctl/config/manifest/clusterctl-api.yaml
- CHANGELOG/v1.12.3.md
- config/crd/bases/ipam.cluster.x-k8s.io_ipaddresses.yaml
- cmd/clusterctl/hack/create-local-repository.py
- CHANGELOG/v1.11.4.md
- cmd/clusterctl/internal/test/fake_github.go
- CHANGELOG/v1.10.9.md
- CHANGELOG/v1.10.10.md
- cmd/clusterctl/cmd/version_checker.go
- cmd/clusterctl/client/config_test.go
- .dockerignore
- CHANGELOG/v1.12.4.md
- controllers/crdmigrator/test/t4/crd/test.cluster.x-k8s.io_testclusters.yaml
- config/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yaml
- CONTRIBUTING.md
- config/crd/bases/runtime.cluster.x-k8s.io_extensionconfigs.yaml
- cmd/clusterctl/client/cluster/cert_manager_test.go
- cmd/clusterctl/client/repository/repository_github_test.go
- CHANGELOG/v1.11.7.md
- controllers/clustercache/cluster_accessor_client.go
- CHANGELOG/v1.12.2.md
- CHANGELOG/v1.12.1.md
🚧 Files skipped from review as they are similar to previous changes (90)
- config/crd/patches/webhook_in_machinesets.yaml
- config/crd/patches/webhook_in_extensionconfigs.yaml
- config/manager/manager.yaml
- controllers/crdmigrator/test/t3/crd/test.cluster.x-k8s.io_testclusters.yaml
- bootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigtemplates.yaml
- config/crd/patches/webhook_in_clusters.yaml
- cmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_metadata.yaml
- CHANGELOG/v1.11.6.md
- config/crd/patches/webhook_in_machinedrainrules.yaml
- config/crd/patches/webhook_in_machinepools.yaml
- CHANGELOG/v1.11.5.md
- config/crd/patches/webhook_in_machines.yaml
- config/crd/patches/webhook_in_clusterresourcesetbindings.yaml
- config/crd/patches/webhook_in_clusterresourcesets.yaml
- bootstrap/kubeadm/internal/cloudinit/utils.go
- config/crd/patches/webhook_in_ipaddresses.yaml
- bootstrap/kubeadm/config/manager/manager.yaml
- cmd/clusterctl/internal/test/fake_reader.go
- .github/workflows/weekly-md-link-check.yaml
- cmd/clusterctl/client/repository/repository_github.go
- bootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigs.yaml
- config/crd/patches/webhook_in_machinedeployments.yaml
- .github/workflows/weekly-test-release.yaml
- bootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate_test.go
- cmd/clusterctl/Dockerfile
- api/ipam/v1alpha1/conversion.go
- cmd/clusterctl/client/cluster/template_test.go
- config/crd/patches/webhook_in_ipaddressclaims.yaml
- api/core/v1beta2/clusterclass_types.go
- config/crd/patches/webhook_in_clusterclasses.yaml
- config/metrics/crd-metrics-config.yaml
- api/runtime/hooks/v1alpha1/topologymutation_types.go
- bootstrap/kubeadm/internal/webhooks/kubeadmconfig_test.go
- cmd/clusterctl/client/upgrade.go
- api/controlplane/kubeadm/v1beta2/kubeadmcontrolplanetemplate_types.go
- api/bootstrap/kubeadm/v1beta1/kubeadm_types.go
- cmd/clusterctl/client/config/providers_client.go
- bootstrap/kubeadm/internal/cloudinit/disk_setup.go
- api/runtime/hooks/v1alpha1/common_types.go
- api/controlplane/kubeadm/v1beta1/kubeadm_control_plane_types.go
- cmd/clusterctl/client/cluster/template.go
- api/core/v1beta1/machine_types.go
- api/core/v1beta2/common_types.go
- cmd/clusterctl/cmd/config_repositories_test.go
- cmd/clusterctl/client/cluster/cert_manager.go
- api/controlplane/kubeadm/v1beta1/kubeadmcontrolplanetemplate_types.go
- controllers/clustercache/cluster_cache_test.go
- bootstrap/kubeadm/internal/locking/control_plane_init_mutex.go
- api/core/v1beta1/common_types.go
- api/core/v1beta2/machine_types.go
- .golangci-kal.yml
- bootstrap/kubeadm/internal/controllers/suite_test.go
- bootstrap/kubeadm/internal/cloudinit/cloudinit_test.go
- api/core/v1beta1/conversion_test.go
- cmd/clusterctl/cmd/describe_cluster.go
- api/core/v1beta1/machinehealthcheck_types.go
- cmd/clusterctl/client/cluster/mover.go
- api/bootstrap/kubeadm/v1beta1/conversion.go
- cmd/clusterctl/client/config/imagemeta_client.go
- api/runtime/hooks/v1alpha1/topologymutation_variable_types.go
- config/crd/bases/cluster.x-k8s.io_machinepools.yaml
- cmd/clusterctl/cmd/upgrade_apply.go
- api/core/v1beta1/cluster_types.go
- api/core/v1beta2/cluster_types.go
- api/controlplane/kubeadm/v1beta1/conversion.go
- controllers/crdmigrator/crd_migrator.go
- cmd/clusterctl/client/cluster/upgrader.go
- api/bootstrap/kubeadm/v1beta1/kubeadmconfig_types.go
- api/core/v1beta2/condition_types.go
- config/crd/bases/cluster.x-k8s.io_machinedeployments.yaml
- bootstrap/kubeadm/internal/webhooks/kubeadmconfig.go
- bootstrap/kubeadm/internal/setup/setup.go
- api/controlplane/kubeadm/v1beta2/kubeadm_control_plane_types.go
- bootstrap/util/configowner_test.go
- config/crd/bases/cluster.x-k8s.io_machinesets.yaml
- Tiltfile
- api/bootstrap/kubeadm/v1beta2/kubeadmconfig_types.go
- api/runtime/hooks/v1alpha1/lifecyclehooks_types.go
- bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
- api/core/v1beta1/clusterclass_types.go
- .golangci.yml
- bootstrap/kubeadm/main.go
- config/crd/bases/cluster.x-k8s.io_machines.yaml
- bootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate.go
- config/crd/bases/addons.cluster.x-k8s.io_clusterresourcesetbindings.yaml
- cmd/clusterctl/client/config/imagemeta_client_test.go
- controllers/clustercache/cluster_cache.go
- controllers/clustercache/cluster_accessor.go
- config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml
- api/core/v1beta1/conversion.go
cloud-team-bot
Bot
force-pushed
the
rebase-bot-main
branch
from
1e84737 to
51f2e5c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
CHANGELOG/v1.13.0-beta.1.md (1)
148-148:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove the extra space in the Runtime SDK bullet.
client cert/keyshould beclient cert/key.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG/v1.13.0-beta.1.md` at line 148, In the CHANGELOG file, locate the bullet point about Runtime SDK client certificate/key rotation and remove the extra space between "client" and "cert/key" so that it reads "client cert/key" instead of "client cert/key".CHANGELOG/v1.13.0-beta.0.md (1)
81-81:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove the extra space in the Runtime SDK bullet.
client cert/keyshould beclient cert/key.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG/v1.13.0-beta.0.md` at line 81, In the CHANGELOG entry for Runtime SDK on line 81, there is an extra space between "client" and "cert/key" in the text "Improve client cert/key rotation". Remove the extra space so that "client cert/key" becomes "client cert/key" to maintain proper formatting in the changelog.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG/v1.13.0-rc.0.md`:
- Line 1: The pull request is missing the required change-type label for
documentation changes. Since this PR modifies the CHANGELOG markdown file (a
documentation change), you need to add the 📖 label to the pull request in
addition to the existing `needs-ok-to-test` label. Navigate to the PR's label
section and add the 📖 documentation label to comply with the project's labeling
policy for documentation changes.
---
Duplicate comments:
In `@CHANGELOG/v1.13.0-beta.0.md`:
- Line 81: In the CHANGELOG entry for Runtime SDK on line 81, there is an extra
space between "client" and "cert/key" in the text "Improve client cert/key
rotation". Remove the extra space so that "client cert/key" becomes "client
cert/key" to maintain proper formatting in the changelog.
In `@CHANGELOG/v1.13.0-beta.1.md`:
- Line 148: In the CHANGELOG file, locate the bullet point about Runtime SDK
client certificate/key rotation and remove the extra space between "client" and
"cert/key" so that it reads "client cert/key" instead of "client cert/key".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 591b1bf6-a21e-4e66-abe1-7493c38eaec1
⛔ Files ignored due to path filters (28)
api/bootstrap/kubeadm/v1beta1/zz_generated.conversion.gois excluded by!**/zz_generated*api/bootstrap/kubeadm/v1beta1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/bootstrap/kubeadm/v1beta2/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/controlplane/kubeadm/v1beta1/zz_generated.conversion.gois excluded by!**/zz_generated*api/controlplane/kubeadm/v1beta1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/controlplane/kubeadm/v1beta2/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/core/v1beta1/zz_generated.conversion.gois excluded by!**/zz_generated*api/core/v1beta1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/core/v1beta1/zz_generated.openapi.gois excluded by!**/zz_generated*api/core/v1beta2/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/core/v1beta2/zz_generated.openapi.gois excluded by!**/zz_generated*api/runtime/hooks/v1alpha1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/runtime/hooks/v1alpha1/zz_generated.openapi.gois excluded by!**/zz_generated*docs/book/src/images/clusterclass-crd-relationships.svgis excluded by!**/*.svgdocs/book/src/images/kubeadm-control-plane-machines-resources.pngis excluded by!**/*.pngdocs/book/src/images/worker-machines-resources.pngis excluded by!**/*.pnggo.sumis excluded by!**/*.sumhack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/cloud.google.com/go/auth/CHANGES.mdis excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/credentials/detect.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/credentials/filetypes.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/credentials/internal/gdch/gdch.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/grpctransport/grpctransport.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/httptransport/httptransport.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/httptransport/transport.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/internal/credsfile/credsfile.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/internal/credsfile/filetype.gois excluded by!**/vendor/**hack/tools/vendor/cloud.google.com/go/auth/internal/credsfile/parse.gois excluded by!**/vendor/**
📒 Files selected for processing (271)
.dockerignore.github/workflows/pr-gh-workflow-approve.yaml.github/workflows/pr-md-link-check.yaml.github/workflows/release.yaml.github/workflows/weekly-md-link-check.yaml.github/workflows/weekly-security-scan.yaml.github/workflows/weekly-test-release.yaml.golangci-kal.yml.golangci.yml.trivyignoreCHANGELOG/v1.10.10.mdCHANGELOG/v1.10.9.mdCHANGELOG/v1.11.4.mdCHANGELOG/v1.11.5.mdCHANGELOG/v1.11.6.mdCHANGELOG/v1.11.7.mdCHANGELOG/v1.12.0-rc.1.mdCHANGELOG/v1.12.0.mdCHANGELOG/v1.12.1.mdCHANGELOG/v1.12.2.mdCHANGELOG/v1.12.3.mdCHANGELOG/v1.12.4.mdCHANGELOG/v1.13.0-beta.0.mdCHANGELOG/v1.13.0-beta.1.mdCHANGELOG/v1.13.0-rc.0.mdCONTRIBUTING.mdDockerfileMakefileTiltfileapi/bootstrap/kubeadm/v1beta1/conversion.goapi/bootstrap/kubeadm/v1beta1/kubeadm_types.goapi/bootstrap/kubeadm/v1beta1/kubeadmconfig_types.goapi/bootstrap/kubeadm/v1beta2/kubeadmconfig_types.goapi/controlplane/kubeadm/v1beta1/conversion.goapi/controlplane/kubeadm/v1beta1/kubeadm_control_plane_types.goapi/controlplane/kubeadm/v1beta1/kubeadmcontrolplanetemplate_types.goapi/controlplane/kubeadm/v1beta2/kubeadm_control_plane_types.goapi/controlplane/kubeadm/v1beta2/kubeadmcontrolplanetemplate_types.goapi/core/v1beta1/cluster_types.goapi/core/v1beta1/clusterclass_types.goapi/core/v1beta1/common_types.goapi/core/v1beta1/conversion.goapi/core/v1beta1/conversion_test.goapi/core/v1beta1/machine_types.goapi/core/v1beta1/machinehealthcheck_types.goapi/core/v1beta2/cluster_types.goapi/core/v1beta2/clusterclass_types.goapi/core/v1beta2/common_types.goapi/core/v1beta2/condition_types.goapi/core/v1beta2/machine_types.goapi/ipam/v1alpha1/conversion.goapi/runtime/hooks/v1alpha1/common_types.goapi/runtime/hooks/v1alpha1/lifecyclehooks_types.goapi/runtime/hooks/v1alpha1/topologymutation_types.goapi/runtime/hooks/v1alpha1/topologymutation_variable_types.gobootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yamlbootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yamlbootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigs.yamlbootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigtemplates.yamlbootstrap/kubeadm/config/manager/manager.yamlbootstrap/kubeadm/config/webhook/manifests.yamlbootstrap/kubeadm/internal/cloudinit/cloudinit_test.gobootstrap/kubeadm/internal/cloudinit/disk_setup.gobootstrap/kubeadm/internal/cloudinit/utils.gobootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.gobootstrap/kubeadm/internal/controllers/suite_test.gobootstrap/kubeadm/internal/locking/control_plane_init_mutex.gobootstrap/kubeadm/internal/setup/setup.gobootstrap/kubeadm/internal/webhooks/kubeadmconfig.gobootstrap/kubeadm/internal/webhooks/kubeadmconfig_test.gobootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate.gobootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate_test.gobootstrap/kubeadm/main.gobootstrap/util/configowner_test.gobootstrap/util/suite_test.gocmd/clusterctl/Dockerfilecmd/clusterctl/client/cluster/cert_manager.gocmd/clusterctl/client/cluster/cert_manager_test.gocmd/clusterctl/client/cluster/mover.gocmd/clusterctl/client/cluster/template.gocmd/clusterctl/client/cluster/template_test.gocmd/clusterctl/client/cluster/upgrader.gocmd/clusterctl/client/cluster/upgrader_test.gocmd/clusterctl/client/config/imagemeta_client.gocmd/clusterctl/client/config/imagemeta_client_test.gocmd/clusterctl/client/config/providers_client.gocmd/clusterctl/client/config_test.gocmd/clusterctl/client/repository/repository_github.gocmd/clusterctl/client/repository/repository_github_test.gocmd/clusterctl/client/upgrade.gocmd/clusterctl/cmd/config_repositories_test.gocmd/clusterctl/cmd/describe_cluster.gocmd/clusterctl/cmd/upgrade_apply.gocmd/clusterctl/cmd/version_checker.gocmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_metadata.yamlcmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_providers.yamlcmd/clusterctl/config/manifest/clusterctl-api.yamlcmd/clusterctl/hack/create-local-repository.pycmd/clusterctl/internal/test/fake_github.gocmd/clusterctl/internal/test/fake_reader.goconfig/crd/bases/addons.cluster.x-k8s.io_clusterresourcesetbindings.yamlconfig/crd/bases/addons.cluster.x-k8s.io_clusterresourcesets.yamlconfig/crd/bases/cluster.x-k8s.io_clusterclasses.yamlconfig/crd/bases/cluster.x-k8s.io_clusters.yamlconfig/crd/bases/cluster.x-k8s.io_machinedeployments.yamlconfig/crd/bases/cluster.x-k8s.io_machinedrainrules.yamlconfig/crd/bases/cluster.x-k8s.io_machinehealthchecks.yamlconfig/crd/bases/cluster.x-k8s.io_machinepools.yamlconfig/crd/bases/cluster.x-k8s.io_machines.yamlconfig/crd/bases/cluster.x-k8s.io_machinesets.yamlconfig/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yamlconfig/crd/bases/ipam.cluster.x-k8s.io_ipaddresses.yamlconfig/crd/bases/runtime.cluster.x-k8s.io_extensionconfigs.yamlconfig/crd/patches/webhook_in_clusterclasses.yamlconfig/crd/patches/webhook_in_clusterresourcesetbindings.yamlconfig/crd/patches/webhook_in_clusterresourcesets.yamlconfig/crd/patches/webhook_in_clusters.yamlconfig/crd/patches/webhook_in_extensionconfigs.yamlconfig/crd/patches/webhook_in_ipaddressclaims.yamlconfig/crd/patches/webhook_in_ipaddresses.yamlconfig/crd/patches/webhook_in_machinedeployments.yamlconfig/crd/patches/webhook_in_machinedrainrules.yamlconfig/crd/patches/webhook_in_machinehealthchecks.yamlconfig/crd/patches/webhook_in_machinepools.yamlconfig/crd/patches/webhook_in_machines.yamlconfig/crd/patches/webhook_in_machinesets.yamlconfig/manager/manager.yamlconfig/metrics/crd-metrics-config.yamlconfig/webhook/manifests.yamlcontrollers/clustercache/cluster_accessor.gocontrollers/clustercache/cluster_accessor_client.gocontrollers/clustercache/cluster_accessor_test.gocontrollers/clustercache/cluster_cache.gocontrollers/clustercache/cluster_cache_test.gocontrollers/crdmigrator/crd_migrator.gocontrollers/crdmigrator/test/t1/crd/test.cluster.x-k8s.io_testclusters.yamlcontrollers/crdmigrator/test/t2/crd/test.cluster.x-k8s.io_testclusters.yamlcontrollers/crdmigrator/test/t3/crd/test.cluster.x-k8s.io_testclusters.yamlcontrollers/crdmigrator/test/t4/crd/test.cluster.x-k8s.io_testclusters.yamlcontrolplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanes.yamlcontrolplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanetemplates.yamlcontrolplane/kubeadm/config/crd/patches/webhook_in_kubeadmcontrolplanes.yamlcontrolplane/kubeadm/config/crd/patches/webhook_in_kubeadmcontrolplanetemplates.yamlcontrolplane/kubeadm/config/manager/manager.yamlcontrolplane/kubeadm/config/webhook/manifests.yamlcontrolplane/kubeadm/internal/cluster.gocontrolplane/kubeadm/internal/cluster_test.gocontrolplane/kubeadm/internal/clustercache_utils.gocontrolplane/kubeadm/internal/control_plane.gocontrolplane/kubeadm/internal/control_plane_test.gocontrolplane/kubeadm/internal/controllers/controller.gocontrolplane/kubeadm/internal/controllers/controller_test.gocontrolplane/kubeadm/internal/controllers/fakes_test.gocontrolplane/kubeadm/internal/controllers/helpers.gocontrolplane/kubeadm/internal/controllers/inplace.gocontrolplane/kubeadm/internal/controllers/inplace_canupdatemachine.gocontrolplane/kubeadm/internal/controllers/inplace_canupdatemachine_test.gocontrolplane/kubeadm/internal/controllers/inplace_trigger.gocontrolplane/kubeadm/internal/controllers/remediation.gocontrolplane/kubeadm/internal/controllers/remediation_test.gocontrolplane/kubeadm/internal/controllers/scale.gocontrolplane/kubeadm/internal/controllers/scale_test.gocontrolplane/kubeadm/internal/controllers/status.gocontrolplane/kubeadm/internal/controllers/status_test.gocontrolplane/kubeadm/internal/controllers/suite_test.gocontrolplane/kubeadm/internal/controllers/update.gocontrolplane/kubeadm/internal/controllers/update_test.gocontrolplane/kubeadm/internal/desiredstate/desired_state.gocontrolplane/kubeadm/internal/desiredstate/desired_state_test.gocontrolplane/kubeadm/internal/etcd/etcd_test.gocontrolplane/kubeadm/internal/etcd/fake/client.gocontrolplane/kubeadm/internal/setup/setup.gocontrolplane/kubeadm/internal/suite_test.gocontrolplane/kubeadm/internal/webhooks/kubeadmcontrolplane.gocontrolplane/kubeadm/internal/webhooks/kubeadmcontrolplane_test.gocontrolplane/kubeadm/internal/webhooks/kubeadmcontrolplanetemplate.gocontrolplane/kubeadm/internal/webhooks/scale.gocontrolplane/kubeadm/internal/workload_cluster.gocontrolplane/kubeadm/internal/workload_cluster_conditions.gocontrolplane/kubeadm/internal/workload_cluster_conditions_test.gocontrolplane/kubeadm/internal/workload_cluster_coredns.gocontrolplane/kubeadm/internal/workload_cluster_etcd.gocontrolplane/kubeadm/internal/workload_cluster_etcd_test.gocontrolplane/kubeadm/internal/workload_cluster_rbac.gocontrolplane/kubeadm/internal/workload_cluster_rbac_test.gocontrolplane/kubeadm/internal/workload_cluster_test.gocontrolplane/kubeadm/main.godocs/book/src/SUMMARY.mddocs/book/src/clusterctl/configuration.mddocs/book/src/developer/core/logging.mddocs/book/src/developer/core/tilt.mddocs/book/src/developer/providers/contracts/bootstrap-config.mddocs/book/src/developer/providers/contracts/clusterctl.mddocs/book/src/developer/providers/contracts/control-plane.mddocs/book/src/developer/providers/contracts/infra-cluster.mddocs/book/src/developer/providers/contracts/infra-machine.mddocs/book/src/developer/providers/contracts/infra-machinepool.mddocs/book/src/developer/providers/getting-started/webhooks.mddocs/book/src/developer/providers/migrations/v1.10-to-v1.11.mddocs/book/src/developer/providers/migrations/v1.12-to-v1.13.mddocs/book/src/developer/providers/migrations/v1.9-to-v1.10.mddocs/book/src/images/kubeadm-control-plane-machines-resources.plantumldocs/book/src/images/worker-machines-resources.plantumldocs/book/src/introduction.mddocs/book/src/reference/api/crd-api-reference-v1beta1.mddocs/book/src/reference/api/crd-api-reference.mddocs/book/src/reference/api/crd-relationships.mddocs/book/src/reference/api/reference.mddocs/book/src/reference/versions.mddocs/book/src/tasks/automated-machine-management/healthchecking.mddocs/book/src/tasks/automated-machine-management/scaling.mddocs/book/src/tasks/cluster-resource-set.mddocs/book/src/tasks/diagnostics.mddocs/book/src/tasks/experimental-features/cluster-class/write-clusterclass.mddocs/book/src/tasks/experimental-features/experimental-features.mddocs/book/src/tasks/experimental-features/machine-pools.mddocs/book/src/tasks/experimental-features/runtime-sdk/implement-extensions.mddocs/book/src/tasks/experimental-features/runtime-sdk/index.mddocs/book/src/tasks/external-etcd.mddocs/book/src/tasks/using-kustomize.mddocs/book/src/user/quick-start.mddocs/proposals/20200506-conditions.mddocs/proposals/20210310-opt-in-autoscaling-from-zero.mddocs/proposals/20220330-topology-mutation-hook.mddocs/proposals/20240916-improve-status-in-CAPI-resources.mddocs/proposals/20250124-From CAPD(docker) to CAPD(dev) .mddocs/release/releases/release-1.13.mddocs/release/role-handbooks/ci-signal/README.mddocs/release/role-handbooks/release-lead/README.mdexp/topology/desiredstate/desired_state.goexp/topology/desiredstate/desired_state_test.goexp/topology/desiredstate/lifecycle_hooks.goexp/topology/desiredstate/lifecycle_hooks_test.goexp/topology/desiredstate/upgrade_plan.goexp/topology/desiredstate/upgrade_plan_test.gofeature/feature.gogo.modhack/crd-ref-docs-config-v1beta1.yamlhack/crd-ref-docs-config-v1beta2.yamlhack/ensure-go.shhack/gogcflags.shhack/kind-install.shhack/observability/alloy/kustomization.yamlhack/observability/grafana/chart/kustomization.yamlhack/observability/grafana/dashboards/cluster-api-mgmt-apiserver-requests.jsonhack/observability/grafana/dashboards/cluster-api-performance.jsonhack/observability/grafana/dashboards/cluster-api-state.jsonhack/observability/grafana/dashboards/cluster-api-wl-apiserver-requests.jsonhack/observability/grafana/dashboards/controller-runtime.jsonhack/observability/grafana/dashboards/runtime-extensions.jsonhack/observability/kube-state-metrics/crd-sidecar-patch.yamlhack/observability/kube-state-metrics/kustomization.yamlhack/observability/loki/kustomization.yamlhack/observability/loki/values.yamlhack/observability/metrics-server/kustomization.yamlhack/observability/parca/values.yamlhack/observability/prometheus/kustomization.yamlhack/observability/prometheus/values.yamlhack/observability/tempo/kustomization.yamlhack/observability/visualizer/kustomization.yamlhack/tools/go.modhack/tools/govulncheck/.gitignorehack/tools/govulncheck/govulncheck.patchhack/tools/internal/tilt-prepare/main.gohack/tools/prowjob-gen/config.gohack/tools/prowjob-gen/test/test-configuration.yamlhack/tools/prowjob-gen/test/test-main.yaml.goldenhack/tools/prowjob-gen/test/test.yaml.tplhack/tools/release/internal/update_providers/provider_issues.gohack/tools/release/weekly/main.gohack/tools/runtime-openapi-gen/main.go
💤 Files with no reviewable changes (7)
- bootstrap/kubeadm/config/webhook/manifests.yaml
- .github/workflows/pr-gh-workflow-approve.yaml
- .trivyignore
- config/webhook/manifests.yaml
- cmd/clusterctl/client/cluster/upgrader_test.go
- bootstrap/util/suite_test.go
- controllers/clustercache/cluster_accessor_test.go
✅ Files skipped from review due to trivial changes (42)
- controllers/crdmigrator/test/t4/crd/test.cluster.x-k8s.io_testclusters.yaml
- cmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_providers.yaml
- config/crd/patches/webhook_in_machinedrainrules.yaml
- bootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigtemplates.yaml
- config/crd/patches/webhook_in_clusterresourcesetbindings.yaml
- controllers/crdmigrator/test/t2/crd/test.cluster.x-k8s.io_testclusters.yaml
- cmd/clusterctl/config/manifest/clusterctl-api.yaml
- config/crd/bases/cluster.x-k8s.io_machinedrainrules.yaml
- config/crd/patches/webhook_in_clusterclasses.yaml
- config/crd/patches/webhook_in_extensionconfigs.yaml
- config/crd/patches/webhook_in_ipaddresses.yaml
- config/crd/patches/webhook_in_machines.yaml
- controllers/crdmigrator/test/t1/crd/test.cluster.x-k8s.io_testclusters.yaml
- config/crd/patches/webhook_in_machinesets.yaml
- controllers/crdmigrator/test/t3/crd/test.cluster.x-k8s.io_testclusters.yaml
- config/crd/patches/webhook_in_ipaddressclaims.yaml
- bootstrap/kubeadm/internal/locking/control_plane_init_mutex.go
- config/crd/patches/webhook_in_clusters.yaml
- CHANGELOG/v1.11.4.md
- cmd/clusterctl/client/repository/repository_github_test.go
- CHANGELOG/v1.11.7.md
- CHANGELOG/v1.12.2.md
- CONTRIBUTING.md
- CHANGELOG/v1.12.3.md
- CHANGELOG/v1.11.6.md
- .dockerignore
- CHANGELOG/v1.10.10.md
- config/crd/patches/webhook_in_machinehealthchecks.yaml
- config/crd/bases/runtime.cluster.x-k8s.io_extensionconfigs.yaml
- CHANGELOG/v1.10.9.md
- config/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yaml
- config/metrics/crd-metrics-config.yaml
- cmd/clusterctl/cmd/config_repositories_test.go
- config/crd/bases/ipam.cluster.x-k8s.io_ipaddresses.yaml
- cmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_metadata.yaml
- .golangci-kal.yml
- CHANGELOG/v1.11.5.md
- cmd/clusterctl/hack/create-local-repository.py
- CHANGELOG/v1.12.4.md
- CHANGELOG/v1.12.1.md
- api/core/v1beta2/condition_types.go
- controllers/clustercache/cluster_accessor_client.go
🚧 Files skipped from review as they are similar to previous changes (79)
- config/crd/patches/webhook_in_machinepools.yaml
- cmd/clusterctl/cmd/version_checker.go
- bootstrap/kubeadm/config/manager/manager.yaml
- config/crd/patches/webhook_in_clusterresourcesets.yaml
- config/manager/manager.yaml
- api/controlplane/kubeadm/v1beta1/kubeadmcontrolplanetemplate_types.go
- bootstrap/kubeadm/internal/cloudinit/disk_setup.go
- cmd/clusterctl/internal/test/fake_github.go
- bootstrap/kubeadm/config/crd/patches/webhook_in_kubeadmconfigs.yaml
- config/crd/patches/webhook_in_machinedeployments.yaml
- Dockerfile
- cmd/clusterctl/client/cluster/template.go
- .github/workflows/weekly-md-link-check.yaml
- bootstrap/kubeadm/internal/cloudinit/utils.go
- bootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate_test.go
- api/controlplane/kubeadm/v1beta2/kubeadmcontrolplanetemplate_types.go
- api/core/v1beta2/clusterclass_types.go
- bootstrap/util/configowner_test.go
- bootstrap/kubeadm/internal/controllers/suite_test.go
- api/runtime/hooks/v1alpha1/common_types.go
- cmd/clusterctl/internal/test/fake_reader.go
- api/ipam/v1alpha1/conversion.go
- cmd/clusterctl/client/config_test.go
- cmd/clusterctl/client/cluster/cert_manager_test.go
- .github/workflows/weekly-test-release.yaml
- api/core/v1beta2/common_types.go
- api/core/v1beta1/machinehealthcheck_types.go
- cmd/clusterctl/client/config/providers_client.go
- api/controlplane/kubeadm/v1beta1/kubeadm_control_plane_types.go
- bootstrap/kubeadm/internal/setup/setup.go
- api/core/v1beta2/machine_types.go
- cmd/clusterctl/Dockerfile
- api/core/v1beta1/machine_types.go
- bootstrap/kubeadm/internal/webhooks/kubeadmconfig_test.go
- cmd/clusterctl/client/config/imagemeta_client.go
- controllers/crdmigrator/crd_migrator.go
- controllers/clustercache/cluster_cache_test.go
- api/runtime/hooks/v1alpha1/topologymutation_types.go
- api/bootstrap/kubeadm/v1beta1/kubeadm_types.go
- config/crd/bases/addons.cluster.x-k8s.io_clusterresourcesets.yaml
- cmd/clusterctl/cmd/upgrade_apply.go
- api/core/v1beta1/clusterclass_types.go
- api/runtime/hooks/v1alpha1/topologymutation_variable_types.go
- bootstrap/kubeadm/internal/webhooks/kubeadmconfigtemplate.go
- cmd/clusterctl/client/repository/repository_github.go
- cmd/clusterctl/client/cluster/template_test.go
- cmd/clusterctl/client/cluster/cert_manager.go
- bootstrap/kubeadm/internal/cloudinit/cloudinit_test.go
- bootstrap/kubeadm/internal/webhooks/kubeadmconfig.go
- cmd/clusterctl/client/cluster/upgrader.go
- Tiltfile
- api/bootstrap/kubeadm/v1beta1/conversion.go
- config/crd/bases/addons.cluster.x-k8s.io_clusterresourcesetbindings.yaml
- cmd/clusterctl/client/upgrade.go
- api/core/v1beta1/cluster_types.go
- config/crd/bases/cluster.x-k8s.io_machinehealthchecks.yaml
- bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
- api/bootstrap/kubeadm/v1beta2/kubeadmconfig_types.go
- api/controlplane/kubeadm/v1beta2/kubeadm_control_plane_types.go
- api/controlplane/kubeadm/v1beta1/conversion.go
- cmd/clusterctl/cmd/describe_cluster.go
- api/bootstrap/kubeadm/v1beta1/kubeadmconfig_types.go
- api/core/v1beta1/common_types.go
- api/core/v1beta2/cluster_types.go
- cmd/clusterctl/client/cluster/mover.go
- config/crd/bases/cluster.x-k8s.io_machinesets.yaml
- api/core/v1beta1/conversion_test.go
- cmd/clusterctl/client/config/imagemeta_client_test.go
- .golangci.yml
- config/crd/bases/cluster.x-k8s.io_machines.yaml
- config/crd/bases/cluster.x-k8s.io_machinedeployments.yaml
- config/crd/bases/cluster.x-k8s.io_machinepools.yaml
- controllers/clustercache/cluster_accessor.go
- bootstrap/kubeadm/main.go
- config/crd/bases/cluster.x-k8s.io_clusters.yaml
- controllers/clustercache/cluster_cache.go
- config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml
- api/runtime/hooks/v1alpha1/lifecyclehooks_types.go
- api/core/v1beta1/conversion.go
| @@ -0,0 +1,333 @@ | |||
| 🚨 This is a RELEASE CANDIDATE. Use it only for testing purposes. If you find any bugs, file an [issue](https://github.com/kubernetes-sigs/cluster-api/issues/new). | |||
There was a problem hiding this comment.
Add the required change-type PR label for this markdown change set.
This PR includes documentation/changelog updates, but the provided labels currently show only needs-ok-to-test; please add the required type label (📖 for documentation, per policy).
As per coding guidelines, documentation changes should be labeled with 📖 in PRs; based on learnings, PRs must carry one of the required change-type labels.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG/v1.13.0-rc.0.md` at line 1, The pull request is missing the
required change-type label for documentation changes. Since this PR modifies the
CHANGELOG markdown file (a documentation change), you need to add the 📖 label
to the pull request in addition to the existing `needs-ok-to-test` label.
Navigate to the PR's label section and add the 📖 documentation label to comply
with the project's labeling policy for documentation changes.
Sources: Coding guidelines, Learnings
cloud-team-rebase-bot
Bot
changed the title
cloud-team-bot
Bot
force-pushed
the
rebase-bot-main
branch
from
51f2e5c to
4965328
Compare
Squash follow-up OWNERS sync into the initial OpenShift-specific carry since it updates the same initial ownership surface. # Conflicts: # .github/workflows/pr-dependabot.yaml # .github/workflows/pr-golangci-lint.yaml # .github/workflows/pr-verify.yaml # OWNERS_ALIASES
Squash the OWNERS-only carries into a single update to keep ownership churn in one focused commit.
Squash adjacent changes that iterate on OpenShift manifest tooling and metadata sync behavior in the same Makefile-driven flow.
Squash adjacent Dockerfile updates that refine the 4.21 image carry and manager binary naming.
Squash adjacent toolchain updates touching openshift/tools so kustomize alignment and IPAM pinning are applied together.
…olicy: Ignore Add functions to set the failurePolicy to Ignore for both mutating and validating webhooks handling IPAM resources. During bootstrap, the bootstrap node's Kube API Server receives IPAM create requests but is unable to reach the webhooks in the Cluster API namespace. This is because the bootstrap node doesn't have a route to the pods as it doesn't have access to the pod networks. If failurePolicy is set to Fail, the KAS cannot reach the webhook endpoints and the request fails, preventing creation of IPAddress and IPAddressClaim resources. This causes a chicken-and-egg problem as it prevents IPAM provisioning for the workers which won't start without their IP addresses being allocated. Setting failurePolicy to Ignore allows the resources to be created even when the webhooks are unreachable during bootstrap, matching what Machine API also does. More context: https://redhat-internal.slack.com/archives/C0A2M43S199/p1765540108488539
Squash ART image consistency updates into a single carry commit.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Squash adjacent carries that iterate over OpenShift manifests generation, IPAM kustomization, and Dockerfile image consistency.
… upstream rebase Squash the post-rebase regeneration steps into a single carry commit so the PR keeps one coherent update for generated manifests and dependency vendoring.
Signed-off-by: Nolan Brubaker <[email protected]>
cloud-team-bot
Bot
force-pushed
the
rebase-bot-main
branch
from
4965328 to
c44dfe3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cloud-team-rebase-bot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Deprecations