Skip to content

OCPBUGS-83862: Add conditional update risk for 4.21.0-25 from 4.20.z < 4.20.25 - #10046

Closed
shahsahil264 wants to merge 1 commit into
openshift:masterfrom
shahsahil264:OCPBUGS-83862-auto-sizing-risk
Closed

OCPBUGS-83862: Add conditional update risk for 4.21.0-25 from 4.20.z < 4.20.25#10046
shahsahil264 wants to merge 1 commit into
openshift:masterfrom
shahsahil264:OCPBUGS-83862-auto-sizing-risk

Conversation

@shahsahil264

Copy link
Copy Markdown
Contributor

Summary

Add type: Always conditional update risk for all existing 4.21.z GA releases (4.21.0 through 4.21.25) warning clusters upgrading from 4.20.24 or earlier about the Auto Node Sizing issue.

Context

PR #9494 raises minor_min from 4.20.15 to 4.20.25 for future 4.21.z builds. However, all existing 4.21.z releases were built with the old minor_min, so clusters on 4.20.0-4.20.24 can still see upgrade paths to them.

Per Scott Dodson and W. Trevor King, these existing versions need a conditional update risk to warn affected clusters.

Bug

OCPBUGS-83862: During upgrade from pre-4.20.25, auto-sizing-disabled MachineConfigs override KubeletConfig autosizing settings on custom MachineConfigPool nodes. Fixed in 4.20.25 via openshift/machine-config-operator#5885.

Risk details

  • from: ^4[.]20[.](1?[0-9]|2[0-4])[+].*$ — matches 4.20.0 through 4.20.24
  • type: Always — affects all clusters upgrading from the unpatched version range
  • 26 files: one per GA 4.21.z release (4.21.0 through 4.21.25)

Companion to #9494.

….21.0-25

Warn clusters upgrading from 4.20.24 or earlier to any existing 4.21.z
that auto-sizing-disabled MachineConfigs may override KubeletConfig
autosizing settings on custom MachineConfigPool nodes.

The fix (openshift/machine-config-operator#5885) shipped in 4.20.25.
Clusters should update to 4.20.25+ before upgrading to 4.21.

Companion to openshift#9494 which raises
minor_min for future 4.21.z builds.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Signed-off-by: Sahil Shah <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@shahsahil264: This pull request references Jira Issue OCPBUGS-83862, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.20.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Add type: Always conditional update risk for all existing 4.21.z GA releases (4.21.0 through 4.21.25) warning clusters upgrading from 4.20.24 or earlier about the Auto Node Sizing issue.

Context

PR #9494 raises minor_min from 4.20.15 to 4.20.25 for future 4.21.z builds. However, all existing 4.21.z releases were built with the old minor_min, so clusters on 4.20.0-4.20.24 can still see upgrade paths to them.

Per Scott Dodson and W. Trevor King, these existing versions need a conditional update risk to warn affected clusters.

Bug

OCPBUGS-83862: During upgrade from pre-4.20.25, auto-sizing-disabled MachineConfigs override KubeletConfig autosizing settings on custom MachineConfigPool nodes. Fixed in 4.20.25 via openshift/machine-config-operator#5885.

Risk details

  • from: ^4[.]20[.](1?[0-9]|2[0-4])[+].*$ — matches 4.20.0 through 4.20.24
  • type: Always — affects all clusters upgrading from the unpatched version range
  • 26 files: one per GA 4.21.z release (4.21.0 through 4.21.25)

Companion to #9494.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shahsahil264
Once this PR has been reviewed and has the lgtm label, please assign hlipsig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@shahsahil264: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shahsahil264

Copy link
Copy Markdown
Contributor Author

/assign @wking

@shahsahil264

Copy link
Copy Markdown
Contributor Author

Superseded by #10047 which combines this with #9494 and updates to PromQL scoping per Trevor's feedback.

@openshift-ci-robot

Copy link
Copy Markdown

@shahsahil264: This pull request references Jira Issue OCPBUGS-83862. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Add type: Always conditional update risk for all existing 4.21.z GA releases (4.21.0 through 4.21.25) warning clusters upgrading from 4.20.24 or earlier about the Auto Node Sizing issue.

Context

PR #9494 raises minor_min from 4.20.15 to 4.20.25 for future 4.21.z builds. However, all existing 4.21.z releases were built with the old minor_min, so clusters on 4.20.0-4.20.24 can still see upgrade paths to them.

Per Scott Dodson and W. Trevor King, these existing versions need a conditional update risk to warn affected clusters.

Bug

OCPBUGS-83862: During upgrade from pre-4.20.25, auto-sizing-disabled MachineConfigs override KubeletConfig autosizing settings on custom MachineConfigPool nodes. Fixed in 4.20.25 via openshift/machine-config-operator#5885.

Risk details

  • from: ^4[.]20[.](1?[0-9]|2[0-4])[+].*$ — matches 4.20.0 through 4.20.24
  • type: Always — affects all clusters upgrading from the unpatched version range
  • 26 files: one per GA 4.21.z release (4.21.0 through 4.21.25)

Companion to #9494.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants