Skip to content

OCPBUGS-83894: Bump google.golang.org/grpc to v1.79.3#10422

Open
jkaurredhat wants to merge 1 commit into
openshift:release-4.22from
jkaurredhat:update-grpc-cve-2026-33186
Open

OCPBUGS-83894: Bump google.golang.org/grpc to v1.79.3#10422
jkaurredhat wants to merge 1 commit into
openshift:release-4.22from
jkaurredhat:update-grpc-cve-2026-33186

Conversation

@jkaurredhat

Copy link
Copy Markdown
Contributor

Summary

Update google.golang.org/grpc from v1.60.1 to v1.79.3 to address CVE-2026-33186.

CVE Details

  • CVE-2026-33186: gRPC-Go authorization bypass due to improper HTTP/2 path validation
  • GHSA: GHSA-m425-mq94-257g
  • Component: gRPC-Go server routing logic
  • Patched version: v1.79.3

Vulnerability Description

The gRPC-Go server was too lenient in its routing logic, accepting requests where the :path omitted the mandatory leading slash (e.g., Service/Method instead of /Service/Method). Authorization interceptors evaluated the raw, non-canonical path string, allowing "deny" rules to be bypassed.

Changes

  • Bump google.golang.org/grpc from v1.60.1 to v1.79.3
  • Update vendor/ directory
  • Also updates related dependencies (protobuf, otel, etc.)

Test Plan

  • Build succeeds
  • Existing tests pass
  • Authorization interceptors work correctly

Related: OCPBUGS-83894

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 83384c54-b909-4bc8-a730-338abb489d2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jkaurredhat: This pull request references Jira Issue OCPBUGS-83894, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-83894 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Update google.golang.org/grpc from v1.60.1 to v1.79.3 to address CVE-2026-33186.

CVE Details

  • CVE-2026-33186: gRPC-Go authorization bypass due to improper HTTP/2 path validation
  • GHSA: GHSA-m425-mq94-257g
  • Component: gRPC-Go server routing logic
  • Patched version: v1.79.3

Vulnerability Description

The gRPC-Go server was too lenient in its routing logic, accepting requests where the :path omitted the mandatory leading slash (e.g., Service/Method instead of /Service/Method). Authorization interceptors evaluated the raw, non-canonical path string, allowing "deny" rules to be bypassed.

Changes

  • Bump google.golang.org/grpc from v1.60.1 to v1.79.3
  • Update vendor/ directory
  • Also updates related dependencies (protobuf, otel, etc.)

Test Plan

  • Build succeeds
  • Existing tests pass
  • Authorization interceptors work correctly

Related: OCPBUGS-83894

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2026
@openshift-ci openshift-ci Bot requested review from eliorerz and eranco74 June 1, 2026 17:02
@openshift-ci

openshift-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkaurredhat
Once this PR has been reviewed and has the lgtm label, please assign giladravid16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkaurredhat jkaurredhat force-pushed the update-grpc-cve-2026-33186 branch from 833f595 to 1a68c95 Compare June 1, 2026 17:02
@jkaurredhat

Copy link
Copy Markdown
Contributor Author

/retest-required

@jkaurredhat

Copy link
Copy Markdown
Contributor Author

/test e2e-agent-compact-ipv4
/test e2e-agent-compact-ipv4-iso-no-registry

CVE-2026-33186: Update google.golang.org/grpc from v1.60.1 to v1.79.3
to fix gRPC-Go authorization bypass vulnerability.

- Updated require section with v1.79.3
- Updated vendor directory with patched version
- Used direct dependency update (no replace needed)

Related: OCPBUGS-83894
@jkaurredhat jkaurredhat force-pushed the update-grpc-cve-2026-33186 branch from 1a68c95 to bb20802 Compare June 11, 2026 18:41
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown

@jkaurredhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps bb20802 link true /test verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants