feat: add GitLab CI provider support#559
Open
cgroschupp wants to merge 7 commits into
Open
Conversation
Member
|
Lets say you have an OPKSSH server that accepts both GitLab Login ID Tokens and GitLab-CI ID Tokens. How do you tell the tokens apart? If you use the presence of GQ Signatures to tell them apart, an attacker could simply turn a captured GitLab Login ID Token into a GQ-signed Gitlab-CI ID Tokens and in so doing bind the attackers public key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52
openpubkey/verifier.NewFromManystores provider verifiers in a map keyed by issuer:https://github.com/openpubkey/openpubkey/blob/main/verifier/verifier.go#L126
Because of that, a verifier list cannot contain two providers with the same issuer. If two entries use the same issuer,
NewFromManyrejects them as duplicates.This becomes a problem for GitLab because both normal interactive GitLab login and GitLab CI tokens use the same issuer:
but they require different verification behavior:
GQ256) tokensA server may need to allow both at the same time, for example:
Both entries have the same issuer, but represent different accepted audiences/token types.