Refactor body handling to use ReadableStream - #32
Merged
Conversation
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
4 tasks
james-elicx
reviewed
Jun 23, 2026
…ddleware Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
conico974
force-pushed
the
conico/stream
branch
from
August 1, 2026 09:23
b341910 to
5136f8b
Compare
vicb
approved these changes
Aug 28, 2026
vicb
left a comment
vicb
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks Nico for the PR and James for the review.
I have added a commit to address the stream cancellation feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the handling of request and response bodies to utilize ReadableStream across converters and middleware, improving consistency and performance in body processing.