Skip to content

8386588: [leyden] Improve map file logging to add code cache#115

Closed
Delawen wants to merge 3 commits into
openjdk:premain2from
Delawen:map-file-code-cache
Closed

8386588: [leyden] Improve map file logging to add code cache#115
Delawen wants to merge 3 commits into
openjdk:premain2from
Delawen:map-file-code-cache

Conversation

@Delawen

@Delawen Delawen commented Jun 11, 2026

Copy link
Copy Markdown
Member

Mimicking vnkozlov/jdk#1 for the leyden premain2 repository.

Adding to the assembly mapfile the assets of the code cache.

Tests in https://github.com/Delawen/jdk/actions/runs/27264662339

The map file is generated for example with -Xlog:aot+map=trace,aot+map+oops=trace,aot=warning:file=${FOLDER}/aot.map:none:filesize=0

Example of output:

For NMethods:
Pointer : @@ Nmethod Size Compilation Level Compilation ID Method signature

Fort the rest:
Pointer : @@ Kind Size ID Name

0x00007fbcf7ffeff4: @@ StubGenBlob       25896 73 initial_blob (stub gen)
0x00007fbcf7ffefc8: @@ SharedBlob        403 13 throw_StackOverflowError_blob (shared runtime)
0x00007fbcf7ffef9c: @@ StubGenBlob       3621 74 continuation_blob (stub gen)
0x00007fbcf7ffed34: @@ SharedBlob        2156 0 deopt_blob (shared runtime)
0x00007fbcf7ffe49c: @@ StubGenBlob       129373 75 compiler_blob (stub gen)
0x00007fbcf7ffe470: @@ StubGenBlob       59182 76 final_blob (stub gen)
0x00007fbcf7ffcc8c: @@ C1Blob            650 17 dtrace_object_alloc_blob (C1 runtime)
0x00007fbcf7ffcc60: @@ C1Blob            387 18 unwind_exception_blob (C1 runtime)
0x00007fbcf7ffbe74: @@ C2Blob            335 70 vthread_start_transition_blob (C2 runtime)
0x00007fbcf7ffbe48: @@ Adapter           1333 217 ILIL
0x00007fbcf7ffbe1c: @@ Adapter           1376 218 LIIILLL
0x00007fbcf7ffbdf0: @@ C2Blob            333 71 vthread_end_transition_blob (C2 runtime)
0x00007fbcf7ffbdc4: @@ Adapter           1460 219 LLLIILILLII
0x00007fbcf7ffbd98: @@ Adapter           1342 220 LIIIL
0x00007fbcf7fe5500: @@ Nmethod           2788 2 2906 java.util.concurrent.ConcurrentHashMap$MapEntry.<init>(Ljava/lang/Object;Ljava/lang/Object;Ljava/util/concurrent/ConcurrentHashMap;)V
0x00007fbcf7fe54d4: @@ Nmethod           5552 2 2905 java.util.concurrent.ConcurrentHashMap$EntryIterator.next()Ljava/util/Map$Entry;
0x00007fbcf7fe25e8: @@ Nmethod           11537 4 3183 java.math.BigInteger.subtract([I[I)[I
0x00007fbcf7fe25bc: @@ Nmethod           6965 4 3251 java.util.regex.Pattern$CharProperty.match(Ljava/util/regex/Matcher;ILjava/lang/CharSequence;)Z



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8386588: [leyden] Improve map file logging to add code cache (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/leyden.git pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/115.diff

Using Webrev

Link to Webrev Comment

@Delawen

Delawen commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

@vnkozlov I am not sure if I should try to merge on premain2 or on the JEP PR.

@bridgekeeper

bridgekeeper Bot commented Jun 11, 2026

Copy link
Copy Markdown

👋 Welcome back mariasde! A progress list of the required criteria for merging this PR into premain2 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 11, 2026

Copy link
Copy Markdown

@Delawen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386588: [leyden] Improve map file logging to add code cache

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the premain2 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@Delawen Delawen changed the title feat: Add logging of the contents of the aot cache to the map file JDK-8386588: [leyden] Improve map file logging to add code cache Jun 12, 2026
@openjdk openjdk Bot changed the title JDK-8386588: [leyden] Improve map file logging to add code cache 8386588: [leyden] Improve map file logging to add code cache Jun 12, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 12, 2026
@mlbridge

mlbridge Bot commented Jun 12, 2026

Copy link
Copy Markdown

Webrevs

@Delawen

Delawen commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Windows jobs are failing but it is not related to this change.

@vnkozlov

Copy link
Copy Markdown
Collaborator

@vnkozlov I am not sure if I should try to merge on premain2 or on the JEP PR.

We created premain2 exactly for such work.

@vnkozlov vnkozlov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vnkozlov

Copy link
Copy Markdown
Collaborator

For now let push it into premain2. After JEP is integrated we can push it as followup RFE. May be combine other logging in it.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 12, 2026
@Delawen

Delawen commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Jun 15, 2026
@openjdk

openjdk Bot commented Jun 15, 2026

Copy link
Copy Markdown

@Delawen
Your change (at version b29238f) is now ready to be sponsored by a Committer.

@jerboaa

jerboaa commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Windows GHA build failure is:

configure:60791: Found GNU make version GNU Make 4.4.1 at /usr/bin/make, but it is not for msys (it says: Built for x86_64-pc-cygwin). Ignoring.
configure:61013: error: Cannot find GNU make 3.81 or newer! Please put it in the path, or add e.g. MAKE=/opt/gmake3.81/make as argument to configure.

That's tracked in https://bugs.openjdk.org/browse/JDK-8386551

@jerboaa

jerboaa commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

/sponsor

@openjdk

openjdk Bot commented Jun 15, 2026

Copy link
Copy Markdown

Going to push as commit c0ffd12.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jun 15, 2026
@openjdk openjdk Bot closed this Jun 15, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 15, 2026
@openjdk

openjdk Bot commented Jun 15, 2026

Copy link
Copy Markdown

@jerboaa @Delawen Pushed as commit c0ffd12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Delawen Delawen deleted the map-file-code-cache branch June 15, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants