8386588: [leyden] Improve map file logging to add code cache#115
8386588: [leyden] Improve map file logging to add code cache#115Delawen wants to merge 3 commits into
Conversation
|
@vnkozlov I am not sure if I should try to merge on premain2 or on the JEP PR. |
|
👋 Welcome back mariasde! A progress list of the required criteria for merging this PR into |
|
@Delawen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Windows jobs are failing but it is not related to this change. |
We created |
|
For now let push it into premain2. After JEP is integrated we can push it as followup RFE. May be combine other logging in it. |
|
/integrate |
|
Windows GHA build failure is: That's tracked in https://bugs.openjdk.org/browse/JDK-8386551 |
|
/sponsor |
|
Going to push as commit c0ffd12. |
Mimicking vnkozlov/jdk#1 for the leyden premain2 repository.
Adding to the assembly mapfile the assets of the code cache.
Tests in https://github.com/Delawen/jdk/actions/runs/27264662339
The map file is generated for example with
-Xlog:aot+map=trace,aot+map+oops=trace,aot=warning:file=${FOLDER}/aot.map:none:filesize=0Example of output:
For NMethods:
Pointer: @@NmethodSizeCompilation LevelCompilation IDMethod signatureFort the rest:
Pointer: @@KindSizeIDNameProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/115/head:pull/115$ git checkout pull/115Update a local copy of the PR:
$ git checkout pull/115$ git pull https://git.openjdk.org/leyden.git pull/115/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 115View PR using the GUI difftool:
$ git pr show -t 115Using diff file
Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/115.diff
Using Webrev
Link to Webrev Comment