8381771: Add a check for DNS label not to end with a hyphen

[rm-gh-8]

Backporting JDK-8381771: Add a check for DNS label not to end with a hyphen.

This PR refactors DNSName validation to be more RFC compliant.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/security/x509/GeneralName/DNSNameTest.java
make test TEST=test/jdk/sun/security/x509

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8381771 needs maintainer approval

Issue

• JDK-8381771: Add a check for DNS label not to end with a hyphen (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/602/head:pull/602
$ git checkout pull/602

Update a local copy of the PR:
$ git checkout pull/602
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/602/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 602

View PR using the GUI difftool:
$ git pr show -t 602

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/602.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381771: Add a check for DNS label not to end with a hyphen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• b177fb8: 8382166: [AOT Cache] CRC was not checked on Code Region
• 59e4f5c: 8385165: [ubsan] TestDockerMemoryMetricsSubgroup.java jtreg test fails with ubsan-enabled binaries
• 5a9b65b: 8372546: UnixMultiResolutionSplashTest.java fails intermittently on Ubuntu_24.04
• ... and 8 more: https://git.openjdk.org/jdk25u-dev/compare/b0aebfd297df632fecf3c4027b907519d2de4bbf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (cf7db342)

[rm-gh-8]

/approval request for backport of JDK-8381771: Add a check for DNS label not to end with a hyphen.

This PR refactors DNSName validation to be more RFC-compliant.

For parity with Oracle JDK.

Low Risk - TLS handshake failures for affected hosts are isolated to connections to non-compliant servers.

[openjdk]

@rm-gh-8
8381771: The approval request has been created successfully.