Skip to content

8385454: Provide more NUMA related information in hsinfo/hserr files#600

Open
MBaesken wants to merge 2 commits into
openjdk:masterfrom
openjdk-bots:backport-MBaesken-7a7ee231-master
Open

8385454: Provide more NUMA related information in hsinfo/hserr files#600
MBaesken wants to merge 2 commits into
openjdk:masterfrom
openjdk-bots:backport-MBaesken-7a7ee231-master

Conversation

@MBaesken

@MBaesken MBaesken commented Jun 10, 2026

Copy link
Copy Markdown
Member


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8385454 needs maintainer approval

Issue

  • JDK-8385454: Provide more NUMA related information in hsinfo/hserr files (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/600/head:pull/600
$ git checkout pull/600

Update a local copy of the PR:
$ git checkout pull/600
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 600

View PR using the GUI difftool:
$ git pr show -t 600

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/600.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 10, 2026

Copy link
Copy Markdown

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 7a7ee23168584b5ff80c3cb11360b738089f11c3 8385454: Provide more NUMA related information in hsinfo/hserr files Jun 10, 2026
@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 10, 2026
@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 10, 2026
@mlbridge

mlbridge Bot commented Jun 10, 2026

Copy link
Copy Markdown

Webrevs

@MBaesken

MBaesken commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

The error
error: no matching function for call to ‘StreamIndentor::StreamIndentor(outputStream*&)’
is because "8361712: Improve ShenandoahAsserts printing" is not in 25u-dev.
So we miss the change that brought the default argument for the second parameter of
StreamIndentor(outputStream* os, int indentation = 2) :

@openjdk openjdk Bot removed the clean Identical backport; no merge resolution required label Jun 11, 2026
@MBaesken

Copy link
Copy Markdown
Member Author

I added the default argument value for the second parameter of StreamIndentor .

@TheRealMDoerr TheRealMDoerr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MBaesken

Copy link
Copy Markdown
Member Author

windows aarch64 build failure fails in configure - unrelated .

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 12, 2026
@GoeLin

GoeLin commented Jun 15, 2026

Copy link
Copy Markdown
Member

Hi @MBaesken
please backport to 27 first. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants