Skip to content

8376400: C2: folding ifs may cause incorrect execution when trap is taken#580

Open
rwestrel wants to merge 1 commit into
openjdk:masterfrom
rwestrel:backport-rwestrel-ca405d0e-master
Open

8376400: C2: folding ifs may cause incorrect execution when trap is taken#580
rwestrel wants to merge 1 commit into
openjdk:masterfrom
rwestrel:backport-rwestrel-ca405d0e-master

Conversation

@rwestrel

@rwestrel rwestrel commented May 26, 2026

Copy link
Copy Markdown

Backport is not clean. true_proj() and false_proj() don't exist in
25. The fix for that is trivial. The included test case fails without
the patch and passes with it. tier1 passes.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8376400 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8376400: C2: folding ifs may cause incorrect execution when trap is taken (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/580/head:pull/580
$ git checkout pull/580

Update a local copy of the PR:
$ git checkout pull/580
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 580

View PR using the GUI difftool:
$ git pr show -t 580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/580.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 26, 2026

Copy link
Copy Markdown

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport ca405d0eb2a0ed63dc169aceb80512bf2a523da1 8376400: C2: folding ifs may cause incorrect execution when trap is taken May 26, 2026
@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label May 26, 2026
@rwestrel

Copy link
Copy Markdown
Author

/template append

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@rwestrel The pull request template has been appended to the pull request body

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 26, 2026
@mlbridge

mlbridge Bot commented May 26, 2026

Copy link
Copy Markdown

Webrevs

@chhagedorn chhagedorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.

@openjdk

openjdk Bot commented Jun 15, 2026

Copy link
Copy Markdown

⚠️ @rwestrel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants