Skip to content

8385855: C2: IfNode::filtered_int_type should only allow CmpI #31516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eme64 wants to merge 1 commit into
base: jdk27
Choose a base branch
from
+1,122 −3
Open

8385855: C2: IfNode::filtered_int_type should only allow CmpI #31516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/hotspot/share/opto/ifnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,9 +669,11 @@ const TypeInt* IfNode::filtered_int_type(PhaseGVN* gvn, Node* val, Node* if_proj
BoolNode* bol = iff->in(1)->as_Bool();
if (bol->in(1) && bol->in(1)->is_Cmp()) {
const CmpNode* cmp = bol->in(1)->as_Cmp();
// Val is always the lhs of the comparision: val <test> cmp2
if (cmp->in(1) == val) {
assert(cmp->Opcode() == Op_CmpI, "signed comparison required");
// Val is always the lhs of the comparision: val CmpI cmp2
if (cmp->Opcode() == Op_CmpI && cmp->in(1) == val) {
// Only CmpI allowed, assumed by signed logic below.
// We could extend to CmpU in the future, and would
// have to implement unsigned range logic below.
const TypeInt* cmp2_t = gvn->type(cmp->in(2))->isa_int();
if (cmp2_t != nullptr) {
jint lo = cmp2_t->_lo;
Expand Down
Loading