8386654: Test tools/javac/SystemFilesClosed.java fails on systems without lsof

[dbalek]

When run on systems without lsof, tools/javac/SystemFilesClosed.java fails with the following exception:

java.io.IOException: Cannot run program "lsof": Exec failed, error: 2 (No such file or directory)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1118)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1052)
at SystemFilesClosed.testSystemFilesClosed(SystemFilesClosed.java:89)
...

The proposal is to probe lsof availability at the beginning of the test, before doing the jlink/compile work.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8386654: Test tools/javac/SystemFilesClosed.java fails on systems without lsof (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31514/head:pull/31514
$ git checkout pull/31514

Update a local copy of the PR:
$ git checkout pull/31514
$ git pull https://git.openjdk.org/jdk.git pull/31514/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31514

View PR using the GUI difftool:
$ git pr show -t 31514

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31514.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dbalek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dbalek This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386654: Test tools/javac/SystemFilesClosed.java fails on systems without lsof

Reviewed-by: jpai, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• b123df7: 8385119: Unify boolean value normalization
• e965fcf: 8386124: Test serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does not match
• a47f362: 8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails
• ... and 3 more: https://git.openjdk.org/jdk/compare/52c76a2a5950a5586b2e45791a24a6041d4932b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dbalek The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4b72543c)
• 00: Full (b8ecbf33)

[jaikiran]

Thank you for the update. This looks good to me. Before integrating, it would be good to run the entire tier1 tests in our CI once to verify that this works as expected.

[vicente-romero-oracle]

lgtm