8386595: Two java/net/MulticastSocket tests fail on machines with no ipv6 address other than loopback#31512
Draft
ArnoZeller wants to merge 2 commits into
Draft
8386595: Two java/net/MulticastSocket tests fail on machines with no ipv6 address other than loopback#31512ArnoZeller wants to merge 2 commits into
ArnoZeller wants to merge 2 commits into
Conversation
|
👋 Welcome back azeller! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@ArnoZeller The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests java/net/MulticastSocket/Test.java and java/net/MulticastSocket/NoLoopbackPackets.java fail on a Linux server with IPv6 enabled for loopback interface but not for another interface.
They better check not only for any available IPv6 interface, but ensure that it is not only the loopback interface. The join relys on routing and the loopback interface cannot be used for routing as far as I understand.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31512/head:pull/31512$ git checkout pull/31512Update a local copy of the PR:
$ git checkout pull/31512$ git pull https://git.openjdk.org/jdk.git pull/31512/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31512View PR using the GUI difftool:
$ git pr show -t 31512Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31512.diff