8386625: Devkit could not be built on glibc 2.43+

[YaSuenag]

I saw following error when I tried to build Linux x86_64 devkit on glibc 2.43 system (Fedora 44):

/usr/src/jdk/build/devkit/src/binutils-2.43/gprofng/libcollector/iolib.c: In function 'is_not_the_log_
file':
/usr/src/jdk/build/devkit/src/binutils-2.43/gprofng/libcollector/iolib.c:898:18: error: expected ident
ifier before '_Generic'
  898 | if (CALL_UTIL (strstr)(fname, SP_LOG_FILE) == NULL)
      | ^~~~~~
/usr/src/jdk/build/devkit/src/binutils-2.43/gprofng/libcollector/iolib.c:898:7: note: in expansion of
macro 'CALL_UTIL'
  898 | if (CALL_UTIL (strstr)(fname, SP_LOG_FILE) == NULL)
      | ^~~~~~~~~
  GEN doc/strings.1
mv -f .deps/libgp_collector_la-gethrtime.Tpo .deps/libgp_collector_la-gethrtime.Plo
make[7]: *** [Makefile:645: libgp_collector_la-iolib.lo] Error 1

According to release notes of glibc 2.43, _Generic macro has been introduced as a part of C23, and it might break some packages [1]. It is binutils in devkit.

It is not a bug in OpenJDK and devkit, but it is better if we can avoid the problem with some options. The problem is in gprofng, so we can avoid the problem if we can add --disable-gprofng in configure options of binutils. gprofng is a profiler, so it is not required for devkit.

Note that we cannot build Linux x86_64 devkit on Fedora 44 (glibc 2.43 + gcc 16.1) with this change only. We also need to add -std=gnu17. I exclude it from this change (so far) because we can add it via CFLAGS environment variable and I'm not sure how it affects in older C compilers.

[1] https://sourceware.org/glibc/wiki/Release/2.43#C23_Const-Preserving_Standard_Library_Macros_May_Break_Some_Packages

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8386625: Devkit could not be built on glibc 2.43+ (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31511/head:pull/31511
$ git checkout pull/31511

Update a local copy of the PR:
$ git checkout pull/31511
$ git pull https://git.openjdk.org/jdk.git pull/31511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31511

View PR using the GUI difftool:
$ git pr show -t 31511

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31511.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386625: Devkit could not be built on glibc 2.43+

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e69453fa)

[YaSuenag]

/integrate

[openjdk]

Going to push as commit 23aa48f.
Since your change was applied there have been 12 commits pushed to the master branch:

• 05ab67a: 8385651: HotCodeSampler crashes with JFR enabled
• 1251526: 8386287: GenShen: assert(starts_object(card_index)) failed: Can't get last start because no object starts here
• b123df7: 8385119: Unify boolean value normalization
• ... and 9 more: https://git.openjdk.org/jdk/compare/d4acb51b33c7a45e740b9713c77f661d757f880e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@YaSuenag Pushed as commit 23aa48f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.