Skip to content

8385746: S390: Improve receiver type profiling reliability#31510

Open
offamitkumar wants to merge 2 commits into
openjdk:masterfrom
offamitkumar:type_profile
Open

8385746: S390: Improve receiver type profiling reliability#31510
offamitkumar wants to merge 2 commits into
openjdk:masterfrom
offamitkumar:type_profile

Conversation

@offamitkumar

@offamitkumar offamitkumar commented Jun 13, 2026

Copy link
Copy Markdown
Member

s390 port, other architectures have already been ported.

Testing:

  • s390x-linux-fastdebug : tier1 + hotspot_compiler


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8385746: S390: Improve receiver type profiling reliability (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31510/head:pull/31510
$ git checkout pull/31510

Update a local copy of the PR:
$ git checkout pull/31510
$ git pull https://git.openjdk.org/jdk.git pull/31510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31510

View PR using the GUI difftool:
$ git pr show -t 31510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31510.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 13, 2026

Copy link
Copy Markdown

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 13, 2026

Copy link
Copy Markdown

@offamitkumar This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk Bot changed the title 8385746 8385746: S390: Improve receiver type profiling reliability Jun 13, 2026
@openjdk

openjdk Bot commented Jun 13, 2026

Copy link
Copy Markdown

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 13, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 13, 2026
@mlbridge

mlbridge Bot commented Jun 13, 2026

Copy link
Copy Markdown

Webrevs

@shipilev shipilev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable port of the original change.

@offamitkumar

Copy link
Copy Markdown
Member Author

@TheRealMDoerr can you take a look at this, as it is derived from ppc changes.

@TheRealMDoerr TheRealMDoerr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that s390 also has instructions for counted loops which would probably generate shorter code. Nevertheless, looks correct.

Comment thread src/hotspot/cpu/s390/macroAssembler_s390.cpp
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 15, 2026
@openjdk openjdk Bot removed the ready Pull request is ready to be integrated label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants