Skip to content

Support Cap 7 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
papiguy wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Support Cap 7 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ecd2c5a
capacitor 6
wainwrightmark Oct 8, 2024
3d72dcc
Capacitor 6 support
RLUCT1 Nov 7, 2024
1721c3e
Update README.md
RLUCT1 Nov 8, 2024
38b9595
Update package.json
RLUCT1 Nov 8, 2024
37360f9
Update package.json
boengli Dec 12, 2024
d236a59
Update package.json
boengli Dec 12, 2024
bbe0635
push dist
boengli Dec 12, 2024
1739bab
Capacitor 7 support
boengli Apr 28, 2025
5deebc9
update to capacitor 0.7.0
wainwrightmark Jul 15, 2025
07c9f7c
Merge pull request #1 from wainwrightmark/main
papiguy Sep 30, 2025
6e2c249
Merge pull request from boengli/capacitor-game-connect main branch
anchukhanna Sep 30, 2025
1ebb29a
modernize code and lib
anchukhanna Sep 30, 2025
f8ca849
fix builds
anchukhanna Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# node files
dist/
node_modules/

# iOS files
Expand All @@ -17,6 +16,14 @@ xcuserdata
*.apk
*.ap_

# IDE and Editor directories and files
.vscode/
.idea/
*.sublime-project
*.sublime-workspace
*.swp
*~

# Files for the ART/Dalvik VM
*.dex

Expand Down
4 changes: 2 additions & 2 deletions OpenforgeCapacitorGameConnect.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Pod::Spec.new do |s|
s.author = package['author']
s.source = { :git => package['repository']['url'], :tag => s.version.to_s }
s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
s.ios.deployment_target = '13.0'
s.ios.deployment_target = '14.0'
s.dependency 'Capacitor'
s.swift_version = '5.1'
s.swift_version = '5.9'

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Swift version has been updated from 5.1 to 5.9. While this aligns with modern Swift versions, ensure that:

  1. All Swift code in the project is compatible with Swift 5.9
  2. This change is documented in migration notes for developers
  3. Minimum Xcode version requirements are updated accordingly (Swift 5.9 requires Xcode 15.0+)

This is a significant version jump that may introduce breaking changes for consumers using older Xcode versions.

Suggested change
s.swift_version = '5.9'
s.swift_versions = ['5.1', '5.9']

Copilot uses AI. Check for mistakes.
end
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ Capacitor plugin for connecting and using services by Apple Game Center and Goog
---

| Capacitor Version | Support Status |
| ----------- | :----: |
| Capacitor v5 | ✅ |
| Capacitor v4 | ✅ |
| Capacitor v3 | ✅ |
| Capacitor v2 | ❌ |
| Capacitor v1 | ❌ |
|-------------------|:--------------:|
| Capacitor v7 | TESTING |

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README indicates Capacitor v7 is marked as "TESTING" rather than fully supported. However:

  1. The package.json version has been bumped to 7.0.0, suggesting this is a release version
  2. The PR title "Support Cap 7" suggests completion rather than testing phase
  3. This creates confusion about the actual support status

Consider either:

  • Marking v7 as fully supported (✅) if it's ready for release
  • Using a pre-release version (e.g., 7.0.0-beta.1) if still in testing
  • Clarifying in the PR description what "TESTING" means for end users

Copilot uses AI. Check for mistakes.
| Capacitor v6 | ✅ |
| Capacitor v5 | ✅ |
| Capacitor v4 | ✅ |
| Capacitor v3 | ✅ |

✅ - Supported
🚧 - WIP Support
Expand Down
3 changes: 0 additions & 3 deletions android/.idea/.gitignore
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions android/.idea/compiler.xml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions android/.idea/gradle.xml
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions android/.idea/jarRepositories.xml
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions android/.idea/misc.xml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions android/.idea/vcs.xml
View file
Open in desktop

This file was deleted.

20 changes: 10 additions & 10 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ext {
junitVersion = project.hasProperty('junitVersion') ? rootProject.ext.junitVersion : '4.13.2'
androidxAppCompatVersion = project.hasProperty('androidxAppCompatVersion') ? rootProject.ext.androidxAppCompatVersion : '1.6.1'
androidxJunitVersion = project.hasProperty('androidxJunitVersion') ? rootProject.ext.androidxJunitVersion : '1.1.5'
androidxEspressoCoreVersion = project.hasProperty('androidxEspressoCoreVersion') ? rootProject.ext.androidxEspressoCoreVersion : '3.5.1'
androidxAppCompatVersion = project.hasProperty('androidxAppCompatVersion') ? rootProject.ext.androidxAppCompatVersion : '1.7.1'
androidxJunitVersion = project.hasProperty('androidxJunitVersion') ? rootProject.ext.androidxJunitVersion : '1.2.1'
androidxEspressoCoreVersion = project.hasProperty('androidxEspressoCoreVersion') ? rootProject.ext.androidxEspressoCoreVersion : '3.6.1'
}

buildscript {
Expand All @@ -11,18 +11,18 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:8.0.0-beta03'
classpath 'com.android.tools.build:gradle:8.7.2'
}
}

apply plugin: 'com.android.library'

android {
namespace "com.openforge.capacitorgameconnect"
compileSdkVersion project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 33
compileSdk project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 35
defaultConfig {
minSdkVersion project.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : 22
targetSdkVersion project.hasProperty('targetSdkVersion') ? rootProject.ext.targetSdkVersion : 33
minSdkVersion project.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : 23
targetSdkVersion project.hasProperty('targetSdkVersion') ? rootProject.ext.targetSdkVersion : 35
versionCode 1
versionName "1.0"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand All @@ -33,12 +33,12 @@ android {
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
}
}
lintOptions {
lint {
abortOnError false
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
sourceCompatibility JavaVersion.VERSION_21
targetCompatibility JavaVersion.VERSION_21
Comment on lines +40 to +41

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java version has been updated from VERSION_17 to VERSION_21. This is a significant upgrade that:

  1. Requires developers to have JDK 21 installed
  2. May introduce compatibility issues with older build environments
  3. Should be documented in migration notes

Ensure this aligns with Capacitor 7's requirements and that all developers and CI/CD systems are prepared for this change.

Suggested change
sourceCompatibility JavaVersion.VERSION_21
targetCompatibility JavaVersion.VERSION_21
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17

Copilot uses AI. Check for mistakes.
}
}

Expand Down
Binary file modified android/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
5 changes: 3 additions & 2 deletions android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#Fri Sep 22 06:21:28 CST 2023
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
30 changes: 22 additions & 8 deletions android/gradlew
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 21 additions & 16 deletions android/gradlew.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions android/local.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
# Location of the SDK. This is only used by Gradle.
# For customization when using a Version Control System, please read the
# header note.
#Wed Jul 12 16:16:16 CST 2023
sdk.dir=/Users/ricardomadrid/Library/Android/sdk
#Mon Sep 29 22:50:37 PDT 2025
sdk.dir=/Users/aadikhanna/Library/Android/sdk
Comment on lines +7 to +8

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local.properties file contains a developer-specific SDK path (/Users/aadikhanna/Library/Android/sdk) which should not be committed to version control. This file should remain in .gitignore as it's machine-specific and can cause build issues for other developers. Additionally, the date comment shows "Mon Sep 29 22:50:37 PDT 2025" which appears to be in the future (the current date context shows February 2026).

Suggested change
#Mon Sep 29 22:50:37 PDT 2025
sdk.dir=/Users/aadikhanna/Library/Android/sdk
sdk.dir=/path/to/Android/sdk

Copilot uses AI. Check for mistakes.

@jedihacks jedihacks Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@papiguy could you take a look at this?

Loading