fix: use pull_request instead of pull_request_target for run-tests - #117
Open
vtushar06 wants to merge 1 commit into
Open
fix: use pull_request instead of pull_request_target for run-tests#117vtushar06 wants to merge 1 commit into
vtushar06 wants to merge 1 commit into
Conversation
Signed-off-by: Tushar Verma <[email protected]>
Contributor
Author
|
heads up, you'll see two run-tests entries here, the failing 7s one is the old pull_request_target run using base's current workflow, the passing 1m48s one is the new pull_request trigger from this branch actually running the suite. only the second one exists once this merges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-liner.
run-testsdoesn't use any secrets, just runs go vet + bats against the public demo URLs, sopull_request_targetwas giving it elevated access it doesn't need, and now actions/checkout refuses to even check out fork code under that trigger. Switched to plainpull_request, which also happens to fixset-labels'sifcondition (it was checking forpull_requestwhile the trigger waspull_request_target, so it never actually ran).Didn't use
allow-unsafe-pr-checkout: true, that would bring back the exact risk the checkout guard is there to prevent.Fixes #116