feat: support file-backed call arguments#213
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23339ffe15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| throw new CliUsageError(`Unable to read argument file '${filePath}': ${detail}`); | ||
| } | ||
| try { | ||
| const text = new TextDecoder('utf-8', { fatal: true }).decode(contents); |
There was a problem hiding this comment.
When an argument file starts with a UTF-8 BOM, TextDecoder's default BOM handling strips that leading U+FEFF before returning the value. The new docs/changelog advertise exact UTF-8 file values, so files saved with a BOM (common from some Windows editors) are silently changed before being sent to the tool; pass ignoreBOM: true while keeping fatal: true if the byte-for-text value should be preserved exactly.
Useful? React with 👍 / 👎.
1 participant
Summary
key=@pathand--key @pathfor exact UTF-8 file-backed string arguments@@escaping for literal leading@Proof
./runner pnpm check./runner pnpm test(785 passed, 3 skipped)./runner pnpm buildFixes #212