[codex] isolate config tests and remove legacy release archive#206
[codex] isolate config tests and remove legacy release archive#206LDMB123 wants to merge 1 commit into
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 12, 2026, 9:50 AM ET / 13:50 UTC. Summary Reproducibility: not applicable. this is test and repository cleanup, and the relevant isolation behavior is clear from the source path and passing focused run. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Merge the focused fixture isolation and complete the established removal of generated release archives from source control. Do we have a high-confidence way to reproduce the issue? Not applicable; this is test and repository cleanup, and the relevant isolation behavior is clear from the source path and passing focused run. Is this the best way to solve the issue? Yes. The two-line fixture setup narrowly prevents host config imports from affecting the test, and deleting the redundant archive follows established release hygiene. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 37391ce70b3f. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review Proof has been added to the PR body: release asset readback, focused config test output, |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
fdd3d5f to
1373c7e
Compare
Summary
Isolates config CLI tests from the operator home data directory and removes the checked-in legacy
v0.6.2macOS release archive now that the same archive and checksum exist on the GitHub release.The branch was rebased onto current
origin/main(37391ce,[email protected]) before landing validation.Goal (Cherny pattern)
SUCCESS_CRITERION: MCPorter config CLI tests pass with isolated config/data homes, the redundant checked-in release archive is removed without losing release evidence, and the local
mcporterCLI reports the npm latest version.VERIFY_COMMAND: pnpm exec vitest run tests/cli-config-command.test.ts && pnpm run check && mcporter --version
ROLLBACK_COMMAND: git revert HEAD --no-edit
TIMEBOX: PT2H
Validation
v0.6.2confirmedmcporter-macos-arm64-v0.6.2.tar.gzandmcporter-macos-arm64-v0.6.2.tar.gz.sha256are both uploaded release assets.mcporter-macos-arm64-v0.6.2.tar.gz:sha256:f10d87f12794933b1f0d9b793e955342905a19fdc79a89df2e18d9654f7ba9f2.npm view mcporter versionreturned0.12.0./opt/homebrew/bin/mcporter --versionandmcporter --versionboth returned0.12.0afternpm install -g --prefix /opt/homebrew mcporter@latest.pnpm exec vitest run tests/cli-config-command.test.tspassed on rebased PR head1373c7e.pnpm run checkpassed on rebased PR head1373c7e.~/.agents/skills/codex-prepush/codex-prepush.sh origin/mainpassed with no HIGH/CRITICAL findings.Proof
Notes
Submitted from the
LDMB123/mcporterfork because direct push toopenclaw/mcporteris not permitted for this token.