Fix #1164: Update legacy serverlessworkflow.io URLs to open-workflow-specification.org#1165
Conversation
…w.io URLs to open-workflow-specification.org Signed-off-by: David Gutierrez <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR migrates legacy serverlessworkflow.io references to open-workflow-specification.org throughout the spec documentation, schema identifier, and example workflows to align the repository with the new canonical domain.
Changes:
- Updated standard error type URIs and event
sourcefields in spec docs and use-case docs to the new domain. - Updated example YAML workflows to use the new domain for standard error type URIs and sample event sources.
- Updated the workflow JSON Schema
$idand refreshed community/README + main README website link.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| use-cases/managing-github-issues/README.md | Updates emitted event source URIs and standard runtime error type URIs to the new domain. |
| use-cases/managing-ev-charging-stations/README.md | Updates standard runtime error type URI to the new domain. |
| schema/workflow.yaml | Updates the schema $id to the new canonical domain. |
| README.md | Updates the website badge link target to the new domain. |
| examples/try-catch.yaml | Updates standard communication error type URI to the new domain. |
| examples/try-catch-then.yaml | Updates standard communication error type URI to the new domain. |
| examples/try-catch-retry-reusable.yaml | Updates standard communication error type URI to the new domain. |
| examples/try-catch-retry-inline.yaml | Updates standard communication error type URI to the new domain. |
| examples/call-asyncapi-subscribe-consume-forever-foreach.yaml | Updates sample event source URI to the new domain. |
| dsl.md | Updates standard error type URIs referenced in DSL prose to the new domain. |
| dsl-reference.md | Updates standard error type URIs (and related examples) to the new domain. |
| community/README.md | Updates community presentations link to the new domain. |
Comments suppressed due to low confidence (1)
dsl-reference.md:553
- Same issue as above: the link text is an error type URI, but the hyperlink target points to GitHub instead of the relevant section in this document.
> On success the output of the call is the JSON-RPC result. On failure, runtimes must raise an error with type [https://open-workflow-specification.org/spec/1.0.0/errors/runtime](https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#standard-error-types).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| $id: https://serverlessworkflow.io/schemas/1.0.3/workflow.yaml | |||
| $id: https://open-workflow-specification.org/schemas/1.0.3/workflow.yaml | |||
| [<img src="http://img.shields.io/badge/Website-blue?style=flat&logo=google-chrome&logoColor=white">](https://open-workflow-specification.org/) | ||
| [<img src="http://img.shields.io/badge/Slack-4A154B?style=flat&logo=slack&logoColor=white">](https://cloud-native.slack.com/messages/open-workflow) |
ricardozanini
left a comment
There was a problem hiding this comment.
@dgutierr the CI is failing because we need to update it to the new schema ID.
| @@ -1,4 +1,4 @@ | |||
| $id: https://serverlessworkflow.io/schemas/1.0.3/workflow.yaml | |||
| $id: https://open-workflow-specification.org/schemas/1.0.3/workflow.yaml | |||
| [<img src="http://img.shields.io/badge/Website-blue?style=flat&logo=google-chrome&logoColor=white">](https://open-workflow-specification.org/) | ||
| [<img src="http://img.shields.io/badge/Slack-4A154B?style=flat&logo=slack&logoColor=white">](https://cloud-native.slack.com/messages/open-workflow) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
schema/workflow.yaml:1
- The schema $id was updated, but the CI schema validator still looks up the workflow schema by the old id ("https://serverlessworkflow.io/schemas/1.0.3/workflow.yaml") in .ci/validation/src/index.ts:27. That will make ajv.getSchema(...) return undefined and cause validation to fail unless the validator’s workflowSchemaId is updated to match this new $id.
$id: https://open-workflow-specification.org/schemas/1.0.3/workflow.yaml
README.md:6
- These badge image URLs use plain HTTP. Switching to HTTPS avoids mixed-content warnings and ensures the README assets are fetched securely.
[<img src="http://img.shields.io/badge/Website-blue?style=flat&logo=google-chrome&logoColor=white">](https://open-workflow-specification.org/)
[<img src="http://img.shields.io/badge/Slack-4A154B?style=flat&logo=slack&logoColor=white">](https://cloud-native.slack.com/messages/open-workflow)
| errors: | ||
| with: | ||
| type: https://serverlessworkflow.io.io/dsl/errors/types/communication | ||
| type: https://open-workflow-specification.org/dsl/errors/types/communication |
Summary
serverlessworkflow.iodomain references toopen-workflow-specification.orgacross 12 fileshttps://prefix and double.iosuffix indsl-reference.md$id, standard error type URIs, eventsourcefields, website badge, and community link all updatedraise-inline.yamlandraise-reusable.yamlleft unchanged (not standard error URIs)Closes #1164
Test plan
schema/workflow.yaml$idpoints tohttps://open-workflow-specification.org/schemas/1.0.3/workflow.yamldsl-reference.mdtable all use new domain0.xschemas and custom error examples are untouched