iris: expire idle external OpenCode eval serves#51
Open
penfever wants to merge 11 commits into
Open
Conversation
* fix(iris): persist external eval Harbor artifacts to S3 * style: format durable external eval launcher test --------- Co-authored-by: Benjamin Feuer <[email protected]>
Co-authored-by: Benjamin Feuer <[email protected]>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
Dependency note: do not merge this launcher change until marin-community/marin#7553 has landed. #51 forwards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults the federated external OpenCode eval launcher to a one-hour model-request idle timeout.
The launcher forwards
--idle-timeout-hours 1.0tomarin-serve iris, and no longer carries the stale RunAI-only--model-loader-extra-config={"distributed":true}flag. The timeout is implemented by Marin PR #7553; it deliberately ignores readiness, health, and model-discovery probes.Validation:
pytest tests/iris/test_launch_external_opencode_eval.py -q(12 passed).