-
Notifications
You must be signed in to change notification settings - Fork 992
Add MetricReader interface #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmacd
merged 26 commits into
open-telemetry:main
from
reyang:reyang/metrics-sdk-metricreader
Sep 9, 2021
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
435c422
add MetricReader interface
reyang f50922d
fix link
reyang 38b61a4
Merge branch 'main' into reyang/metrics-sdk-metricreader
reyang 7623003
add the base exporting metricreader
reyang b3f0fe0
update diagram
reyang 0c2fa70
clarify reentrancy for OnCollect
reyang 4e003a8
describe how MetricReader is registered to MeterProvider
reyang d60f4ff
Merge branch 'main' into reyang/metrics-sdk-metricreader
reyang 6716bd7
Update specification/metrics/sdk.md
reyang c42cbc6
Update specification/metrics/sdk.md
reyang 24379f2
Merge branch 'main' into reyang/metrics-sdk-metricreader
reyang b1b5b2c
update toc
reyang 1305453
address review comments
reyang ee5f5b8
fix heading
reyang 104d65a
fix typo
reyang f6bff7c
Merge branch 'main' into reyang/metrics-sdk-metricreader
reyang fd9dfc4
add clarification and example for multiple readers
reyang 5029131
update the PR based on discussion during the SIG meeting
reyang ee04190
cleanup
reyang b2e2fad
cleanup
reyang 86a2c6d
clarify the wording
reyang 47f74e9
adjust wording for pull exporter
reyang 7977fbf
remove base exporting metric reader, mention that it can be an option…
reyang 756d65c
Merge branch 'main' into reyang/metrics-sdk-metricreader
reyang 68f4fdc
change default exporting interval to 60sec
reyang afafa2c
Merge branch 'main' into reyang/metrics-sdk-metricreader
jmacd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.