move pnpm overrides - #1092
Merged
Merged
Conversation
Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
force-pushed
the
fix/pnpm-overrides
branch
from
June 16, 2026 06:39
bce93ff to
9de4d6f
Compare
Signed-off-by: Aaron Chong <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
=======================================
Coverage 63.09% 63.09%
=======================================
Files 260 260
Lines 7747 7747
Branches 1181 1181
=======================================
Hits 4888 4888
Misses 2619 2619
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
koonpeng
requested changes
Jun 16, 2026
| steps: | ||
| - name: Install dependencies | ||
| run: (pnpm install --filter ${{ inputs.package }}... || (pnpm approve-builds --all && pnpm install --filter ${{ inputs.package }}...)) | ||
| run: (pnpm install --filter ${{ inputs.package }}... --no-frozen-lockfile || (pnpm approve-builds --all && pnpm install --filter ${{ inputs.package }}... --no-frozen-lockfile)) |
Collaborator
There was a problem hiding this comment.
Don't think we should use --no-frozen-lockfile. If it fails with --frozen-lockfile, it usually means the lockfile is out of sync and we should commit an updated lockfile instead.
| '@swc/core': true | ||
| protobufjs: true | ||
|
|
||
| overrides: |
Collaborator
There was a problem hiding this comment.
Good to document the use of these overrides. Usually they indicate some form of tech debt and will bite us back in the future.
Signed-off-by: Aaron Chong <[email protected]>
koonpeng
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Move pnpm overrides (added when fixing security issues) to
pnpm-workspace.yaml, due to deprecation of the override parameters in package.jsonGenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: