Skip to content

chore: Renovate config - #155

Open
thompson-tomo wants to merge 3 commits into
open-feature:mainfrom
thompson-tomo:renovate_config
Open

chore: Renovate config#155
thompson-tomo wants to merge 3 commits into
open-feature:mainfrom
thompson-tomo:renovate_config

Conversation

@thompson-tomo

Copy link
Copy Markdown

This PR

  • introduces control of when renovate pr’s are raised
  • groups update’s together to reduce qty

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 03def4bf-b25a-459c-8efc-feabe945a607

📥 Commits

Reviewing files that changed from the base of the PR and between 0755435 and 9f6ea0a.

📒 Files selected for processing (1)
  • renovate.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread renovate.json
@thompson-tomo
thompson-tomo requested a review from erka July 30, 2026 10:16

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
renovate.json (1)

13-13: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use cron schedules instead of deprecated Later text.

Renovate’s text-based before ... on ... syntax is deprecated in favor of five-part cron. Convert the repository’s schedule entries from Later text to cron if Weekday means Monday–Friday.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@renovate.json` at line 13, Update the schedule entry in renovate.json from
deprecated Later text to a five-part cron expression representing execution
before 6:00 AM on weekdays (Monday through Friday). Preserve the existing
scheduling intent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@renovate.json`:
- Line 13: Update the schedule entry in renovate.json from deprecated Later text
to a five-part cron expression representing execution before 6:00 AM on weekdays
(Monday through Friday). Preserve the existing scheduling intent.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 03def4bf-b25a-459c-8efc-feabe945a607

📥 Commits

Reviewing files that changed from the base of the PR and between 0755435 and 9f6ea0a.

📒 Files selected for processing (1)
  • renovate.json

@erka

erka commented Jul 30, 2026

Copy link
Copy Markdown
Member

Hey @thompson-tomo

Thank you for your PR and the follow-up.

Personally, I think the configuration file should look like this:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["github>open-feature/community-tooling"],
  "packageRules": [
    //... rust specific rules only
  ]
}

There should not be any custom rules for GitHub actions, schedule, etc... The community has made their decisions about them. Maintaining each repository separately requires extra effort. For example, people are usually busy with work at their companies on Mondays. Applying the change in one place helps avoid unnecessary noise across multiple repositories and be consistent.

If config:best-practices is the better default it probably should be applied in open-feautre/community-tooling repo. If anything should differ from community-tooling, it should be clearly documented.

@thompson-tomo

Copy link
Copy Markdown
Author

The issue i have with the community rules, is that every single update is requiring 2 approvals (1st to create, 2nd on the pr with a time delay between them). If you have 5 patches thats 10 approvals and the bigger the repo, the bigger the problem. Whereas having 1 patches pr group increases the chance of updates being approved and that pr can sit open till you are ready with new patches being added to it as time goes by. Hence this decreases work needed.

I am more than open to adding some of this config to the community to help repos more efficiently maintain their dependencies.

@erka

erka commented Jul 30, 2026

Copy link
Copy Markdown
Member

Trusted GitHub Actions would be merged without additional approvals. All other changes usually require approval from a maintainer and an owner anyway. I may also have my own opinions on this, but those decisions are made by the Governance and Technical Committees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants