ci: Fix action pinning - #154
Conversation
📝 WalkthroughWalkthroughGitHub Actions workflows update third-party action references to newer or explicit commit SHAs, with version comments added where applicable. Workflow logic and action inputs remain unchanged. ChangesWorkflow action pinning
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/rust.yml:
- Around line 23-25: Add persist-credentials: false to the checkout steps at
.github/workflows/rust.yml lines 23-25 and 65-67,
.github/workflows/flagd-ofrep-check.yml lines 22-24, and
.github/workflows/release-please.yml lines 48-51, preserving their existing
checkout options.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4c6c9e46-c462-434a-baaf-7451ff633263
📒 Files selected for processing (5)
.github/workflows/component-owners.yml.github/workflows/flagd-ofrep-check.yml.github/workflows/lint-pr.yml.github/workflows/release-please.yml.github/workflows/rust.yml
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| submodules: recursive |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Disable persisted checkout credentials across all workflows.
Each checkout leaves GITHUB_TOKEN in .git/config by default. Add persist-credentials: false at every site below, especially before commands that execute repository code.
.github/workflows/rust.yml#L23-L25: add the setting to the build checkout..github/workflows/rust.yml#L65-L67: add the setting to the lint checkout..github/workflows/flagd-ofrep-check.yml#L22-L24: add the setting to the validation checkout..github/workflows/release-please.yml#L48-L51: add the setting to the release checkout.
🧰 Tools
🪛 zizmor (1.28.0)
[warning] 23-25: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
📍 Affects 3 files
.github/workflows/rust.yml#L23-L25(this comment).github/workflows/flagd-ofrep-check.yml#L22-L24.github/workflows/release-please.yml#L48-L51
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/rust.yml around lines 23 - 25, Add persist-credentials:
false to the checkout steps at .github/workflows/rust.yml lines 23-25 and 65-67,
.github/workflows/flagd-ofrep-check.yml lines 22-24, and
.github/workflows/release-please.yml lines 48-51, preserving their existing
checkout options.
Source: Linters/SAST tools
This PR
Follow-up Tasks
Improve renovate config