Skip to content

fix: scope peribolos concurrency per ref#560

Merged
toddbaert merged 1 commit into
mainfrom
fix/peribolos-concurrency-queue
Jul 2, 2026
Merged

fix: scope peribolos concurrency per ref#560
toddbaert merged 1 commit into
mainfrom
fix/peribolos-concurrency-queue

Conversation

@toddbaert

@toddbaert toddbaert commented Jul 2, 2026

Copy link
Copy Markdown
Member

Small addendum to #555, so that we don't share concurrency across ALL runs (just per branch).

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Modified the concurrency configuration in the peribolos GitHub Actions workflow file, replacing cancel-in-progress: false with queue: max under the peribolos concurrency group, along with updated explanatory comments.

Changes

Workflow Concurrency Update

Layer / File(s) Summary
Queue-based concurrency configuration
.github/workflows/peribolos.yaml
Replaced cancel-in-progress: false with queue: max under the peribolos concurrency group and updated comments to reflect that pending runs are queued rather than cancelled.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related Issues: None specified

Related PRs: None specified

Suggested Labels: ci, github-actions

Suggested Reviewers: None specified

Poem
A rabbit hops through YAML lines,
Where "cancel" once left telltale signs,
Now queues line up, patient and neat,
No run discarded, all runs complete,
A tiny change, but tidy and fine! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is about the concurrency change, though it emphasizes per-ref scoping more than the queueing update.
Description check ✅ Passed The description is directly related to the workflow concurrency change and the shift from shared to branch-scoped runs.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@toddbaert toddbaert force-pushed the fix/peribolos-concurrency-queue branch from acf7110 to b88f637 Compare July 2, 2026 15:02
@toddbaert toddbaert temporarily deployed to peribolos-verify July 2, 2026 15:02 — with GitHub Actions Inactive
@toddbaert toddbaert force-pushed the fix/peribolos-concurrency-queue branch from b88f637 to 96d1253 Compare July 2, 2026 15:02
@toddbaert toddbaert changed the title fix: queue peribolos runs instead of cancelling fix: scope peribolos concurrency to apply, cancel stale Jul 2, 2026
@toddbaert toddbaert temporarily deployed to peribolos-verify July 2, 2026 15:02 — with GitHub Actions Inactive
@toddbaert toddbaert changed the title fix: scope peribolos concurrency to apply, cancel stale fix: queue only peribolos apply Jul 2, 2026
@toddbaert toddbaert force-pushed the fix/peribolos-concurrency-queue branch from 96d1253 to 49b4d6c Compare July 2, 2026 15:04
@toddbaert toddbaert temporarily deployed to peribolos-verify July 2, 2026 15:04 — with GitHub Actions Inactive
@toddbaert toddbaert changed the title fix: queue only peribolos apply fix: split peribolos verify and apply into separate jobs Jul 2, 2026
@toddbaert toddbaert force-pushed the fix/peribolos-concurrency-queue branch from 49b4d6c to df99f2e Compare July 2, 2026 15:05
@toddbaert toddbaert temporarily deployed to peribolos-verify July 2, 2026 15:05 — with GitHub Actions Inactive
@toddbaert toddbaert force-pushed the fix/peribolos-concurrency-queue branch from df99f2e to 9722a3c Compare July 2, 2026 15:05
@toddbaert toddbaert temporarily deployed to peribolos-verify July 2, 2026 15:06 — with GitHub Actions Inactive
The default GitHub Actions concurrency behavior cancels any pending
run when a new one enters the same group, regardless of
`cancel-in-progress: false`. This meant the ofep archival push run
got evicted by later PR verify runs.

Scope the group by ref so PR runs don't queue against the apply on
main, and switch to `cancel-in-progress: true` so the newest apply
wins (peribolos is idempotent against current config).

Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert force-pushed the fix/peribolos-concurrency-queue branch from 9722a3c to bb5c7e0 Compare July 2, 2026 15:07
@toddbaert toddbaert changed the title fix: split peribolos verify and apply into separate jobs fix: scope peribolos concurrency per ref Jul 2, 2026
@toddbaert toddbaert temporarily deployed to peribolos-verify July 2, 2026 15:07 — with GitHub Actions Inactive
@toddbaert toddbaert merged commit 5ead060 into main Jul 2, 2026
3 checks passed
@toddbaert toddbaert deleted the fix/peribolos-concurrency-queue branch July 2, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant