feat: add support for typesafe object flags#248
Conversation
Signed-off-by: Michael Beemer <[email protected]>
|
Hey @kriscoleman and @tomflenner, I'm still experimenting with this but I figured I'd get early feedback from both of you. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for an optional 'schema' field on object-type feature flags, enabling type-safe code generation and runtime validation across multiple languages (Go, TypeScript, Java, C#, Python). It includes updates to the CLI command structure to support a '--runtime-validation' flag, adds documentation for the new schema capabilities, and provides comprehensive test coverage for the generated code and validation logic. All review comments regarding missing trailing newlines in golden files and sample manifests have been identified as actionable improvements and are being addressed.
| return new GeneratedClient(Api.Instance.GetClient(domain)); | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
It's a good practice to end files with a newline character. Please add a newline at the end of this file.
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
It's a good practice to end files with a newline character. Please add a newline at the end of this file.
| return client.getObjectDetails("themeCustomization", {"header":{"fontSize":16,"visible":true},"primaryColor":"#007bff","secondaryColor":"#6c757d","tags":["light"]}, context, { ...options, hooks: [...(options?.hooks ?? []), createThemeCustomizationHook()] }) as Promise<EvaluationDetails<ThemeCustomization>>; | ||
| }, | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
It's a good practice to end files with a newline character. Please add a newline at the end of this file.
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
It's a good practice to end files with a newline character. Please add a newline at the end of this file.
1 participant
This PR
Notes
This is a bit of an experiment. We can scrape the idea, but I think this could be very valuable as the line between feature flagging and dynamic configuration continues to blur.
Follow-up Tasks
I need to double-check that the validators work as expected in all SDKs.
How to test
I've updated all the tests and manually tested the Node.js generator.