all: Fix most mismatches

[GRAnimated]

Fixes 15 mismatches in BOTW, 80 mismatches in SMO, and improves the score on the rest of the mismatches.

All found by GPT 5.6 Sol in about 12 hours

---

This change is 

[MonsterDruide1]

Am I understanding correctly, that I should not review things here yet, but wait for you to perform a few more checks with it?

[GRAnimated]

I was hoping that BOTW would get further than a compilation error, so that files without a BOTW regression could be reviewed. I'll setup botw and work on it locally. (also I forgot to set it as a draft, thanks)

[GRAnimated]

Now ready for review

[Pistonight]

I wonder how much did it cost to run the model for 12 hours for this?

[GRAnimated]

Just a $20/month Codex subscription. I'd loosely estimate usage to be around ~25 million input and maybe 5 million output tokens. If I were going through Codex pricing and I had 90% cache hits, that would be ~$175 in API costs. I was using a small workaround, but if you were using the plan as intended then you'd be able to do this all within the weekly limit.

[MonsterDruide1]

@MonsterDruide1 reviewed 14 files and all commit messages, and made 6 comments.
Reviewable status: 14 of 32 files reviewed, 6 unresolved discussions (waiting on GRAnimated).

---

include/framework/seadMethodTree.h line 34 at r4 (raw file):

    using PauseEventDelegate = IDelegate2<MethodTreeNode*, PauseFlag>;

    explicit MethodTreeNode(CriticalSection* cs) : TTreeNode(this), INamable("")

Suggestion:

explicit MethodTreeNode(CriticalSection* cs) : TTreeNode(this)

---

include/framework/seadMethodTree.h line 81 at r4 (raw file):

    mutable CriticalSection* mCriticalSection;
    [[maybe_unused]] u32 mPriority;
    u32 mPauseFlag;

Suggestion:

BitFlag32 mPauseFlag;

---

modules/src/filedevice/seadFileDeviceMgr.cpp line 361 at r4 (raw file):

void FileDeviceMgr::unmountSaveDataForDebug() {}
#endif
#endif

Suggestion:

#ifdef NNSDK
void FileDeviceMgr::mountSaveDataForDebug(Heap*)
{
#ifdef SEAD_DEBUG
    const auto result = nn::fs::MountSaveDataForDebug("save");
    SEAD_ASSERT_MSG(
        result.IsSuccess(),
        "nn::fs::MountSaveDataForDebug() failed. module = %d desc = %d innervalue = 0x%08x",
        result.GetModule(), result.GetDescription(), result.GetInnerValueForDebug());
#endif
}

void FileDeviceMgr::unmountSaveDataForDebug()
{
#ifdef SEAD_DEBUG
    nn::fs::Unmount("save");
#endif
}
#endif

---

modules/src/filedevice/seadPath.cpp line 60 at r4 (raw file):

    u32 dot_index = rfindCharIndex(path, '.');
    if (dot_index == 0xFFFFFFFF)

Suggestion:

    u32 dot_index = rfindCharIndex(path, '.');
    if (dot_index == -1)

---

modules/src/filedevice/nin/seadNinFileDeviceBaseNin.cpp at r4 (raw file):
Deleting these warnings seems wrong, are you sure they aren't gated by #ifdef SEAD_DEBUG?

---

modules/src/framework/seadMethodTree.cpp line 91 at r4 (raw file):

    auto* node = child();
    if (node && !(mPauseFlag & cPause_Child))

Suggestion:

    if (mPauseFlag.isOff(cPause_Self))
        (*mDelegateHolder.data())();

    auto* node = child();
    if (node && mPauseFlag.isOff(cPause_Child))